-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change JsonSchemaPrimitive to a class #9913
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandr-shegeda
approved these changes
Feb 8, 2022
tuliren
reviewed
Feb 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Looks good in general.
One major thing is that currently it is possible to construct an invalid JsonSchemaType
instance. This class and its builder can be refactored to eliminate that possibility.
airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/airbyte_protocol.py
Outdated
Show resolved
Hide resolved
airbyte-protocol/models/src/main/java/io/airbyte/protocol/models/JsonSchemaType.java
Outdated
Show resolved
Hide resolved
airbyte-protocol/models/src/main/java/io/airbyte/protocol/models/JsonSchemaType.java
Outdated
Show resolved
Hide resolved
airbyte-protocol/models/src/main/java/io/airbyte/protocol/models/JsonSchemaType.java
Show resolved
Hide resolved
40 tasks
tuliren
reviewed
Feb 14, 2022
airbyte-server/src/test/java/io/airbyte/server/helpers/ConnectionHelpers.java
Outdated
Show resolved
Hide resolved
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/platform
issues related to the platform
area/protocol
area/scheduler
area/server
area/worker
Related to worker
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Currently all jdbc connectors can provide only primitive json types
( STRING, NUMBER, OBJECT, ARRAY, BOOLEAN, NULL)
and json schema looks like
{ "type": "string" },
{ "type": "number" }
How
Created JsonSchemaType class to construct json schema with any parameters.
Please find the details in the RFC document.
Recommended reading order
JsonSchemaType.java
JdbcSourceOperations.java
The rest of the files just include JsonSchemaPrimitive to JsonSchemaType replacement.
🚨 User Impact 🚨
There should not be visible user impact
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes