Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Facebook Marketing: Add AdAccount and Images stream implementation #10180

Merged
merged 9 commits into from
Feb 9, 2022
Merged

🎉 Source Facebook Marketing: Add AdAccount and Images stream implementation #10180

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cdd38fa
Add AdAccount and Images stream implementation
lazebnyi Feb 8, 2022
65539b2
Update PR number
lazebnyi Feb 8, 2022
a911e12
Merge branch 'master' into lazebnyi/9840-add-adaccount-and-images-str…
lazebnyi Feb 8, 2022
72a36c1
Updated docker version
lazebnyi Feb 8, 2022
dcc581b
Merge master to branch
lazebnyi Feb 8, 2022
a283e33
Updated to linter
lazebnyi Feb 8, 2022
083ca38
Update to review
lazebnyi Feb 9, 2022
30003f3
Add comment to AdAccount read_records method
lazebnyi Feb 9, 2022
6c8f59f
Bumped version in seed, definitions and specs files
lazebnyi Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-facebook-marketing/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.2.32
LABEL io.airbyte.version=0.2.33
LABEL io.airbyte.name=airbyte/source-facebook-marketing
4 changes: 2 additions & 2 deletions airbyte-integrations/connectors/source-facebook-marketing/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ and place them into `secrets/config.json`.
python main.py spec
python main.py check --config secrets/config.json
python main.py discover --config secrets/config.json
python main.py read --config secrets/config.json --catalog sample_files/configured_catalog.json
python main.py read --config secrets/config.json --catalog integration_tests/configured_catalog.json
```

### Locally running the connector docker image
Expand All @@ -73,7 +73,7 @@ Then run any of the connector commands as follows:
docker run --rm airbyte/source-facebook-marketing:dev spec
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-facebook-marketing:dev check --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-facebook-marketing:dev discover --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/sample_files:/sample_files airbyte/source-facebook-marketing:dev read --config /secrets/config.json --catalog /sample_files/configured_catalog.json
docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/sample_files:/sample_files airbyte/source-facebook-marketing:dev read --config /secrets/config.json --catalog /integration_tests/configured_catalog.json
```
## Testing
Make sure to familiarize yourself with [pytest test discovery](https://docs.pytest.org/en/latest/goodpractices.html#test-discovery) to know how your test files and methods should be named.
Expand Down
2 changes: 2 additions & 0 deletions airbyte-integrations/connectors/source-facebook-marketing/acceptance-test-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,5 @@ tests:
ignored_fields:
"ads_insights_age_and_gender": ["cost_per_estimated_ad_recallers"]
"ad_creatives": ["thumbnail_url"]
"ad_account": ["age"]
"images": ["permalink_url"]
30 changes: 30 additions & 0 deletions ...tegrations/connectors/source-facebook-marketing/integration_tests/configured_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,36 @@
"cursor_field": ["date_start"],
"destination_sync_mode": "append",
"primary_key": null
},
{
"stream": {
"name": "images",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["updated_time"],
"source_defined_primary_key": [["id"]],
"namespace": null
},
"sync_mode": "incremental",
"cursor_field": null,
"destination_sync_mode": "append",
"primary_key": null
},
{
"stream": {
"name": "ad_account",
"json_schema": {},
"supported_sync_modes": ["full_refresh"],
"source_defined_cursor": null,
"default_cursor_field": null,
"source_defined_primary_key": [["id"]],
"namespace": null
},
"sync_mode": "full_refresh",
"cursor_field": null,
"destination_sync_mode": "append",
"primary_key": null
}
]
}
30 changes: 30 additions & 0 deletions ...tors/source-facebook-marketing/integration_tests/configured_catalog_without_insights.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,36 @@
"cursor_field": null,
"destination_sync_mode": "append",
"primary_key": null
},
{
"stream": {
"name": "images",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["updated_time"],
"source_defined_primary_key": [["id"]],
"namespace": null
},
"sync_mode": "incremental",
"cursor_field": null,
"destination_sync_mode": "append",
"primary_key": null
},
{
"stream": {
"name": "ad_account",
"json_schema": {},
"supported_sync_modes": ["full_refresh"],
"source_defined_cursor": null,
"default_cursor_field": null,
"source_defined_primary_key": [["id"]],
"namespace": null
},
"sync_mode": "full_refresh",
"cursor_field": null,
"destination_sync_mode": "append",
"primary_key": null
}
]
}
4 changes: 4 additions & 0 deletions ...yte-integrations/connectors/source-facebook-marketing/integration_tests/future_state.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
"updated_time": "2121-07-25T13:34:26Z",
"include_deleted": true
},
"images": {
"updated_time": "2121-07-25T13:34:26Z",
"include_deleted": true
},
"ad_creatives": {
"updated_time": "2121-07-25T13:34:26Z",
"include_deleted": true
Expand Down
Loading