-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Facebook Marketing: Add AdAccount and Images stream implementation #10180
🎉 Source Facebook Marketing: Add AdAccount and Images stream implementation #10180
Conversation
/test connector=connectors/source-facebook-marketing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the comments for schemas.
...egrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/images.json
Outdated
Show resolved
Hide resolved
...egrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/images.json
Outdated
Show resolved
Hide resolved
...egrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/images.json
Outdated
Show resolved
Hide resolved
...egrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/images.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
several minor comments
airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/streams.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/streams.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please publish your changes
/publish connector=connectors/source-facebook-marketing
|
What
#9842 - Facebook Marketing Source: Support "Replicate Incremental Deletes"
#9840 - Facebook Marketing Source: Add "Ad Account" stream
#6226 - Facebook Marketing Source: Add "Ad Image" stream
How
Added
AdAccount
andAdImage
streams implementation.Added to docs info about Incremental Deletes Sync.
Recommended reading order
x.java
y.python
Pre-merge Checklist
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog example