fix: Update DEFAULT_ERROR_MAPPING for InvalidURL to RETRY #384
Conversation
📝 WalkthroughWalkthroughThis update refines the error handling in the HTTP stream logic. The error mapping for an Changes
Sequence Diagram(s)sequenceDiagram
participant Stream as HTTP Stream
participant EH as Error Handler
participant Logger as Logger
Note over Stream: An InvalidURL (or DNS) error occurs
Stream->>EH: Handle InvalidURL exception
EH-->>Stream: Return ErrorResolution(response_action=RETRY, failure_type=transient_error)
sequenceDiagram
participant Test as Unit Test
participant StubStream as StubHttpStreamWithErrorHandler
participant EH as Error Handler
Test->>StubStream: Simulate InvalidURL exception (with potential DNS error)
StubStream->>EH: Retrieve error handler via get_error_handler()
EH-->>StubStream: Provide ErrorResolution with RETRY and transient_error
Test-->>Test: Assert the error resolution matches expected retry behavior
Would you like any further refinements to these diagrams? wdyt? 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (6)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
* main: ci: add Docker build workflow for PR checks (airbytehq#385) fix: Update DEFAULT_ERROR_MAPPING for InvalidURL to RETRY (airbytehq#384) chore: use python base image 4.0.0 in SDM (airbytehq#382) ci: add check for 'do not merge' in PR titles (airbytehq#383) chore: remove embedded module (airbytehq#380) build: update pyarrow to ^19.0.0 (do not merge) (airbytehq#379)
Solves: https://github.com/airbytehq/airbyte-internal-issues/issues/11320
Updating action to retry should have no adverse effect since the stream will still fail once it exceeds the retry amounts. The retry should allow the sync to continue if it is an actual DNS error. If it is an actual URL error, the stream will fail after it exceeds the maximum retry amount.
Summary by CodeRabbit
Bug Fixes
Tests