Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove embedded module #380

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Removes the embedded module from the airbyte-python-cdk repository as requested.

Link to Devin run: https://app.devin.ai/sessions/a062e4002b7940048f4484c184747536

Co-Authored-By: natik@airbyte.io <natik@airbyte.io>
Copy link
Contributor Author

devin-ai-integration bot commented Mar 4, 2025

🤖 Devin AI Engineer

Original prompt from natik@airbyte.io:

Hey @Devin, can you make a PR that removes the `embedded` module of the airbyte-python-cdk please?

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions github-actions bot added the chore label Mar 4, 2025
Co-Authored-By: natik@airbyte.io <natik@airbyte.io>
@natikgadzhi natikgadzhi changed the title chore: remove embedded module (do not merge) chore: remove embedded module Mar 4, 2025
Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When tests pass, this is fine.

@natikgadzhi natikgadzhi marked this pull request as ready for review March 4, 2025 19:31
@natikgadzhi natikgadzhi enabled auto-merge (squash) March 4, 2025 19:31
@natikgadzhi
Copy link
Contributor

Since this is technically breaking, we should probably do a 7.0 release.

@natikgadzhi natikgadzhi merged commit caa24a0 into main Mar 4, 2025
25 checks passed
@natikgadzhi natikgadzhi deleted the devin/1741115435-remove-embedded-module branch March 4, 2025 20:27
rpopov added a commit to rpopov/airbyte-python-cdk that referenced this pull request Mar 5, 2025
* main:
  ci: add Docker build workflow for PR checks (airbytehq#385)
  fix: Update DEFAULT_ERROR_MAPPING for InvalidURL to RETRY (airbytehq#384)
  chore: use python base image 4.0.0 in SDM (airbytehq#382)
  ci: add check for 'do not merge' in PR titles (airbytehq#383)
  chore: remove embedded module (airbytehq#380)
  build: update pyarrow to ^19.0.0 (do not merge) (airbytehq#379)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant