-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use python base image 4.0.0 in SDM #382
Conversation
📝 WalkthroughWalkthroughThis PR updates the Dockerfile to use a newer version of the base image for the Python connector. The update changes the image from Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Dockerfile (1)
8-8
: Base image update looks good!
The update to useairbyte/python-connector-base:4.0.0
with the new digest is consistent with our PR objectives to standardize on Python 3.11. One quick question: since the new base image targets Python 3.11, do we also need to update the version-specific paths later in the Dockerfile (for instance, line 27 still references/usr/local/lib/python3.10/
)? wdyt?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Pytest (Fast)
- GitHub Check: Analyze (python)
Hold up, this no worky worky
|
I fixed it for now, but we need a better solution for potentially broken dockerfiles |
* main: ci: add Docker build workflow for PR checks (airbytehq#385) fix: Update DEFAULT_ERROR_MAPPING for InvalidURL to RETRY (airbytehq#384) chore: use python base image 4.0.0 in SDM (airbytehq#382) ci: add check for 'do not merge' in PR titles (airbytehq#383) chore: remove embedded module (airbytehq#380) build: update pyarrow to ^19.0.0 (do not merge) (airbytehq#379)
This would push all manifest sources that use the CDK to run on Python 3.11.
So far, we have 60+ sources on Python 3.11 base image and things are smooth.
Summary by CodeRabbit