Add group extras to archive #4521
Conversation
| @@ -377,6 +377,12 @@ def _store_entity_data( | |||
| fields_info = reader.metadata.all_fields_info.get(entity_name, {}) | |||
| unique_identifier = reader.metadata.unique_identifiers.get(entity_name, None) | |||
|
|
|||
| if entity_name == NODE_ENTITY_NAME: | |||
There was a problem hiding this comment.
this should eventually be removed, but it requires (a) changes to the export code and (b) a migration
Codecov Report
@@ Coverage Diff @@
## develop #4521 +/- ##
===========================================
+ Coverage 72.67% 79.40% +6.73%
===========================================
Files 480 480
Lines 35073 35080 +7
===========================================
+ Hits 25486 27851 +2365
+ Misses 9587 7229 -2358
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Tests before StrictVersion pass - thanks a lot @chrisjsewell , that's indeed a much more compact and elegant way to add the extras.
Looks like editing import/export starts being more fun again :-)
I've updated the PR description; feel free to use for the commit message
will do thanks! |
fixes #4497
Group extras were introduced recently but not yet exported to AiiDA archives.
This commit adds group extras to the AiiDA archive.
Instead of special-casing deserialization of attributes and extras based on the field name, a
convert_type: "jsonb"is introduced, which is used to indicate JSON-binary fields.