Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export group extras #4514

Closed

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Oct 26, 2020

fixes #4497

Group extras were introduced recently but not yet possible to export.
This commit adds group extras to the AiiDA archive.

@ltalirz ltalirz mentioned this pull request Oct 27, 2020
Group extras were introduced recently but not yet possible to export.
This commit adds group extras to the AiiDA archive.
@ltalirz ltalirz force-pushed the issue_4497_export_group_extras branch from b33ff63 to 6ac7107 Compare October 27, 2020 21:30
@ltalirz ltalirz force-pushed the issue_4497_export_group_extras branch from 4170261 to 6bf0ad9 Compare October 27, 2020 22:30
@chrisjsewell
Copy link
Member

chrisjsewell commented Oct 27, 2020

@ltalirz FYI you don't need any of this code; you can just add:

            "extras": {
                "convert_type": "jsonb"
            },

below:

then add code to handle "jsonb" in deserialize_attributes (i.e. it should just be returned without conversion)

@ltalirz
Copy link
Member Author

ltalirz commented Oct 27, 2020

Closing in favor of #4521

@ltalirz ltalirz closed this Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Group.extras to export archives
2 participants