-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: aggchain-proof-builder #29
Conversation
454f7c8
to
addf3d7
Compare
addf3d7
to
a44d5b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Requesting changes mostly because of the various Default
impls, that sound wrong to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! There are just two places remaining where I think test-only defaults leak into production code :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some comments
Review again after internal discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Though AFAIU the current defaults (anvil-mock-*-rpc
) are still test-only defaults that currently make it into production default settings, which is sad to me.
This being said, I've opened https://github.com/agglayer/protocol-research/issues/121 to track improving our whole configuration setup, and not only this specific place, so we can land for now and improve on it later (but hopefully before anyone else starts running a node)
Description
Initial backbone for the
aggchain-proof-builder
,aggchain-proof-service
.Added connections between services.
Fixes #42
PR Checklist: