Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: aggchain-proof-builder #29

Merged
merged 15 commits into from
Feb 13, 2025
Merged

feat: aggchain-proof-builder #29

merged 15 commits into from
Feb 13, 2025

Conversation

atanmarko
Copy link
Contributor

@atanmarko atanmarko commented Feb 7, 2025

Description

Initial backbone for the aggchain-proof-builder, aggchain-proof-service.

Added connections between services.

Fixes #42

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@atanmarko atanmarko self-assigned this Feb 7, 2025
@atanmarko atanmarko added this to the v0.3.0 milestone Feb 7, 2025
@atanmarko atanmarko force-pushed the feat/aggchain-proof-builder branch 2 times, most recently from 454f7c8 to addf3d7 Compare February 10, 2025 13:38
@atanmarko atanmarko force-pushed the feat/aggchain-proof-builder branch from addf3d7 to a44d5b6 Compare February 10, 2025 13:44
@atanmarko atanmarko marked this pull request as ready for review February 10, 2025 13:44
@atanmarko atanmarko requested a review from a team as a code owner February 10, 2025 13:44
Copy link

@Ekleog-Polygon Ekleog-Polygon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Requesting changes mostly because of the various Default impls, that sound wrong to me.

Freyskeyd
Freyskeyd previously approved these changes Feb 12, 2025
Copy link
Member

@Freyskeyd Freyskeyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some comments

Copy link

@Ekleog-Polygon Ekleog-Polygon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! There are just two places remaining where I think test-only defaults leak into production code :)

Freyskeyd
Freyskeyd previously approved these changes Feb 13, 2025
Copy link
Member

@Freyskeyd Freyskeyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some comments

@atanmarko atanmarko dismissed Ekleog-Polygon’s stale review February 13, 2025 09:43

Review again after internal discussion

Copy link

@Ekleog-Polygon Ekleog-Polygon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Though AFAIU the current defaults (anvil-mock-*-rpc) are still test-only defaults that currently make it into production default settings, which is sad to me.

This being said, I've opened https://github.com/agglayer/protocol-research/issues/121 to track improving our whole configuration setup, and not only this specific place, so we can land for now and improve on it later (but hopefully before anyone else starts running a node)

@Ekleog-Polygon Ekleog-Polygon mentioned this pull request Feb 13, 2025
4 tasks
@atanmarko atanmarko merged commit a0542b2 into main Feb 13, 2025
10 checks passed
@atanmarko atanmarko deleted the feat/aggchain-proof-builder branch February 13, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add aggchain-proof-builder backbone
5 participants