Skip to content

Commit

Permalink
fix: simons review
Browse files Browse the repository at this point in the history
  • Loading branch information
atanmarko committed Feb 12, 2025
1 parent 814a6d4 commit c3668a3
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 9 deletions.
8 changes: 4 additions & 4 deletions crates/aggkit-prover-config/src/aggchain_proof_service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ pub const HTTP_RPC_NODE_BACKOFF_MAX_RETRIES: u32 = 64;
#[derive(Serialize, Deserialize, Clone, Debug)]
#[serde(rename_all = "kebab-case")]
pub struct AggchainProofServiceConfig {
pub aggchain_proof_builder_config: AggchainProofBuilderConfig,
pub proposer_service_config: ProposerServiceConfig,
pub aggchain_proof_builder: AggchainProofBuilderConfig,
pub proposer_service: ProposerServiceConfig,
}

impl AggchainProofServiceConfig {
pub fn default_for_test() -> Self {
AggchainProofServiceConfig {
aggchain_proof_builder_config: AggchainProofBuilderConfig::default_for_test(),
proposer_service_config: ProposerServiceConfig::default_for_test(),
aggchain_proof_builder: AggchainProofBuilderConfig::default_for_test(),
proposer_service: ProposerServiceConfig::default_for_test(),
}
}
}
6 changes: 2 additions & 4 deletions crates/aggkit-prover/src/aggchain_proof/service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,8 @@ pub(crate) struct AggchainProofService {
impl AggchainProofService {
pub fn new(config: &AggchainProofServiceConfig) -> Result<Self, Error> {
Ok(AggchainProofService {
proposer_service: ProposerService::new(&config.proposer_service_config)?,
aggchain_proof_builder: AggchainProofBuilder::new(
&config.aggchain_proof_builder_config,
)?,
proposer_service: ProposerService::new(&config.proposer_service)?,
aggchain_proof_builder: AggchainProofBuilder::new(&config.aggchain_proof_builder)?,
})
}
}
Expand Down
1 change: 0 additions & 1 deletion crates/aggkit-prover/src/aggchain_proof/tests/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ use aggkit_prover_types::v1::{
aggchain_proof_service_client::AggchainProofServiceClient,
aggchain_proof_service_server::AggchainProofServiceServer, GenerateAggchainProofRequest,
};

use http::Uri;
use hyper_util::rt::TokioIo;
use tonic::transport::{Endpoint, Server};
Expand Down

0 comments on commit c3668a3

Please sign in to comment.