Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #40

Merged
merged 2 commits into from
Jan 18, 2018
Merged

Release #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98fac6d
add simple development release process
maleck13 Jan 17, 2018
861638b
Merge branch 'master' into release
maleck13 Jan 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@ TEST_DIRS ?= $(shell sh -c "find $(TOP_SRC_DIRS) -name \\*_test.go \
-exec dirname {} \\; | sort | uniq")
BIN_DIR := $(GOPATH)/bin
SHELL = /bin/bash

LDFLAGS=-ldflags "-w -s -X main.Version=${TAG}"


setup:
@go get github.com/kisielk/errcheck
@go get github.com/goreleaser/goreleaser

build: setup check build_binary

Expand Down Expand Up @@ -46,4 +48,8 @@ check: errcheck vet fmt test-unit
.PHONY: integration
integration:
go build -o mobile ./cmd/mobile
go test ./integration
go test ./integration

.PHONY: release
release: setup
goreleaser --rm-dist
12 changes: 12 additions & 0 deletions doc/creating_a_release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Creating a release

These releases represent an upstream release and not a release of the product.

- Ensure you are on the master branch
- Ensure git is not in a dirty state (ie stuff needs to be committed )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add that we should run integration tests first?

I am hoping, that the level of integration testing that would be suitable for comunity releases would happen in CI, but that is not the case yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not have been merged to master if the tests were failing so I see little benefit in re running them again ping @witmicko

- Create the next logical tag (v0.0.3) ```git tag ``` will show you the current tags. ```git tag v0.0.3``` will create the tag.
- Create and export a valid [github token](https://help.github.com/articles/creating-a-personal-access-token-for-the-command-line/) ```export GITHUB_TOKEN=<token>```
- Run ```make release```

The end result of this should be a new release on the github page https://github.com/aerogear/mobile-cli/releases with all of the
commits since the previous tag.