Release #40
Merged
Release #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbrookes
approved these changes
Jan 17, 2018
AdamSaleh
reviewed
Jan 17, 2018
| These releases represent an upstream release and not a release of the product. | ||
|
|
||
| - Ensure you are on the master branch | ||
| - Ensure git is not in a dirty state (ie stuff needs to be committed ) |
There was a problem hiding this comment.
Should we add that we should run integration tests first?
I am hoping, that the level of integration testing that would be suitable for comunity releases would happen in CI, but that is not the case yet.
There was a problem hiding this comment.
It should not have been merged to master if the tests were failing so I see little benefit in re running them again ping @witmicko
witmicko
approved these changes
Jan 17, 2018
AdamSaleh
approved these changes
Jan 18, 2018
|
In discussion with @AdamSaleh we believe it would be better to let the integration tests run as part of the PR and for this to happen organically rather than calling it out specifically in the doc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Changes proposed in this pull request