Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Existing labels get removed even with sync-labels: false #404

Closed
akihironitta opened this issue Jul 19, 2022 · 2 comments
Closed

Existing labels get removed even with sync-labels: false #404

akihironitta opened this issue Jul 19, 2022 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@akihironitta
Copy link

A possible misbehaviour

Existing labels get removed even configured with:

sync-labels: false  # which is the default

In our repository, we see that the labeler removes an existing label right after the label gets added to an PR by one of our maintainers as observed in Lightning-AI/pytorch-lightning#13703.

Our configuration

Additional context

There's a similar comment in #365 authored by @1bberto

for some reason the labels are not being added to the PR and are also being removed when I add the labels manually
@akihironitta akihironitta mentioned this issue Jul 19, 2022
Merged
8 tasks
jsoref added a commit to jsoref/labeler that referenced this issue Jul 25, 2022
@jsoref
Fix parsing of sync-labels
2a75521 
Inputs are of type String, not Boolean.

Fixes actions#404
jsoref added a commit to jsoref/labeler that referenced this issue Jul 25, 2022
@jsoref
Fix parsing of sync-labels
b571459 
Inputs are of type String, not Boolean.

Fixes actions#404
@jsoref jsoref mentioned this issue Jul 25, 2022
Merged
@imranbarbhuiya imranbarbhuiya mentioned this issue Aug 17, 2022
Merged
@Yaminyam Yaminyam mentioned this issue Sep 20, 2022
Merged
jsoref added a commit to jsoref/labeler that referenced this issue Sep 30, 2022
@jsoref
Fix parsing of sync-labels
f8bb391 
Inputs are of type String, not Boolean.

Fixes actions#404
@ford-at-aws
Copy link

Any update on this issue?

@akihironitta akihironitta changed the title Exiting labels get removed even with sync-labels: false Existing labels get removed even with sync-labels: false Oct 3, 2022
PatrickLef pushed a commit to Memmo-App/labeler that referenced this issue Oct 6, 2022
@jsoref @PatrickLef
Fix parsing of sync-labels
e550a89 
Inputs are of type String, not Boolean.

Fixes actions#404
@Yaminyam Yaminyam mentioned this issue Oct 27, 2022
Merged
@MaksimZhukov MaksimZhukov added the duplicate This issue or pull request already exists label Dec 12, 2022
@MaksimZhukov
Copy link
Contributor

Hello everyone!
I am closing this issue as a duplicate of this one. Please monitor the bug status in scope of that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akihironitta @MaksimZhukov @ford-at-aws