Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix false negatives by the labeler #13722

Merged
merged 5 commits into from
Jul 19, 2022
Merged

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Jul 19, 2022

What does this PR do?

Resolves false negatives.


The important doc section I missed previously is:

One or both fields can be provided for fine-grained matching. Unlike the top-level list, the list of path globs provided to any and all must ALL match against a path for the label to be applied.

The fields are defined as follows:

  • any: match ALL globs against ANY changed path
  • all: match ALL globs against ALL changed paths

https://github.com/actions/labeler/blob/main/README.md#match-object


Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Additional context

Tried a number of experiments in my fork with GHA debug enabled:

so, I'm pretty confident it'll work as we expect this time.


Still not sure why the bot removes the existing labels. actions/labeler#404


cc @carmocca @akihironitta @Borda

@akihironitta akihironitta added the app (removed) Generic label for Lightning App package label Jul 19, 2022
@akihironitta akihironitta changed the title [wip] CI: Fix or remove labeler [wip][randomly labelled] CI: Fix or remove labeler Jul 19, 2022
@github-actions github-actions bot removed the app (removed) Generic label for Lightning App package label Jul 19, 2022
@akihironitta akihironitta added the pl Generic label for PyTorch Lightning package label Jul 19, 2022
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Jul 19, 2022
@akihironitta akihironitta force-pushed the ci/update-labeler-again branch from 85f526a to e411de1 Compare July 19, 2022 01:05
@akihironitta akihironitta added this to the pl:1.7 milestone Jul 19, 2022
@akihironitta akihironitta added the ci Continuous Integration label Jul 19, 2022
@akihironitta akihironitta changed the title [wip][randomly labelled] CI: Fix or remove labeler CI: Fix false positives by the labeler Jul 19, 2022
@akihironitta akihironitta marked this pull request as ready for review July 19, 2022 03:22
@mergify mergify bot added the ready PRs ready to be merged label Jul 19, 2022
@mergify mergify bot requested a review from a team July 19, 2022 09:56
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FP or FN? different in title and description

@akihironitta akihironitta changed the title CI: Fix false positives by the labeler CI: Fix false negatives by the labeler Jul 19, 2022
@akihironitta akihironitta merged commit 904c2fe into master Jul 19, 2022
@akihironitta akihironitta deleted the ci/update-labeler-again branch July 19, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants