Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if the correct number of identifiers was provided in split() #481

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

conradoplg
Copy link
Contributor

Closes #456 and #460

@conradoplg conradoplg requested a review from natalieesk August 17, 2023 19:02
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (87346f4) 77.46% compared to head (dc4be84) 77.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
+ Coverage   77.46%   77.48%   +0.02%     
==========================================
  Files          30       30              
  Lines        2738     2741       +3     
==========================================
+ Hits         2121     2124       +3     
  Misses        617      617              
Files Changed Coverage Δ
frost-core/src/frost/keys.rs 92.30% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpguerra mpguerra mentioned this pull request Aug 18, 2023
26 tasks
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

mergify bot added a commit that referenced this pull request Sep 2, 2023
@mergify mergify bot merged commit f3eb868 into main Sep 2, 2023
@mergify mergify bot deleted the check-number-identifiers branch September 2, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NCC-E008263-9XW] Missing Length Check in Identifiers List
2 participants