Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NCC-E008263-9XW] Missing Length Check in Identifiers List #456

Closed
Tracked by #451
conradoplg opened this issue Jul 26, 2023 · 0 comments · Fixed by #481
Closed
Tracked by #451

[NCC-E008263-9XW] Missing Length Check in Identifiers List #456

conradoplg opened this issue Jul 26, 2023 · 0 comments · Fixed by #481
Assignees
@conradoplg
Milestone
FROST Audit

Comments

@conradoplg
Copy link
Contributor

split() is not validating if the identifier list provided, if any, has the correct length, which can lead to multiple problems. See report for more details.

Check if it matches max_signers and return error otherwise.
@mpguerra mpguerra mentioned this issue Jul 27, 2023
Closed
26 tasks
@conradoplg conradoplg mentioned this issue Aug 17, 2023
Merged
@conradoplg conradoplg self-assigned this Aug 17, 2023
@mpguerra mpguerra added this to the FROST Audit milestone Aug 24, 2023
@mpguerra mpguerra added this to FROST Aug 24, 2023
@mpguerra mpguerra moved this to Review/QA in FROST Aug 24, 2023
@mergify mergify bot closed this as completed in #481 Sep 2, 2023
@github-project-automation github-project-automation bot moved this from Review/QA to Done in FROST Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conradoplg conradoplg

Labels
None yet
Projects
FROST
Archived in project
Milestone
FROST Audit
Development

Successfully merging a pull request may close this issue.

check if the correct number of identifiers was provided in split() ZcashFoundation/frost
2 participants
@conradoplg @mpguerra