Enhance Transaction serialization and deserialization #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction-serde # Conflicts: # xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/jackson/modules/TransactionDeserializer.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once #594 is merged, this PR improves test coverage of all Transaction sub-classes by adding enhanced JSON deserialization coverage for each flavor of each Transaction. For example the Payment transaction can be deserialized via at least three different mechanisms:
By pointing the Jackson ObjectMapper to a Transaction class (in which case, TransactionDeserializer will be engaged, delegating to the Immutable JSON implementation);
By pointing the Jackson ObjectMapper to a Payment class (in which case, the TransactionDeserialer will be skipped and the Transaction interface will be used, delegating to the to the Immutable JSON implementation);
By pointing the Jackson ObjectMapper to the Immutable implementation itself (e.g., an ImmutablePayment).
This PR adds this additional coverage to ensure proper JSON handling by future developers who may change certain aspects of each Transaction's Interface/Immutable or concrete deserializer without realizing that these changes might subtly affect deserialization based on other related classes.
(Note the large line-count of this PR is due to the addition of a Livenet ledger JSON file that will be merged as part of #590)