Fixes #590 #594
Merged
Fixes #590 #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #590 by removing the `Account` property from any incoming `UnlModify` JSON about to be deserialized. This fixes #590 because the JSON returned by the rippled/clio API v1 has a bug where the account value in `UnlModify` transactions is an empty string, when serialized throws an exception because empty string is not a valid Address. By removing the property from incoming JSON, the Java value for the `Account` property is always set to ACCOUNT_ZERO via a default method. Without this fix, the `Account` will also errantly end up in the `unknownFields map of the ultimate Java object, which is incorrect.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
=========================================
Coverage 92.01% 92.02%
- Complexity 1848 1849 +1
=========================================
Files 383 383
Lines 5125 5128 +3
Branches 435 436 +1
=========================================
+ Hits 4716 4719 +3
Misses 273 273
Partials 136 136 ☔ View full report in Codecov by Sentry. |
This was referenced Feb 16, 2025
nkramer44
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #590 by removing the
Accountproperty from any incomingUnlModifyJSON about to be deserialized. This fixes #590 because the JSON returned by the rippled/clio API v1 has a bug where the account value inUnlModifytransactions is an empty string, when serialized throws an exception because empty string is not a valid Address. By removing the property from incoming JSON, the Java value for theAccountproperty is always set to ACCOUNT_ZERO via a default method. Without this fix, theAccountwill also errantly end up in the `unknownFields map of the ultimate Java object, which is incorrect.(Note the large line-count of this PR is due to the addition of a Livenet ledger JSON file used to validate this fix against real data)