Allow shard downloads via HTTP or HTTPS #3578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undertome
force-pushed
the
http-shard-downloads
branch
from
06d5011 to
d23f29f
Compare
scottschurr
approved these changes
Aug 12, 2020
undertome
force-pushed
the
http-shard-downloads
branch
from
d23f29f to
1744365
Compare
undertome
added
the
Ready to merge
ximinez
requested changes
Sep 1, 2020
ximinez
removed
the
Ready to merge
carlhua
added
the
Ready to merge
undertome
force-pushed
the
http-shard-downloads
branch
from
95bd020 to
8ec99e2
Compare
undertome
force-pushed
the
http-shard-downloads
branch
from
8ec99e2 to
649d4a7
Compare
Merged
mDuo13
added a commit
to mDuo13/xrpl-dev-portal
that referenced
this pull request
Feb 23, 2021
Documents XRPLF/rippled#3578 Also updates the Japanese version of the page for some changes in v1.6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the
HTTPDownloader(formerlySSLHTTPDownloader) to download files via HTTP or HTTPS. When downloading shards, theShardArchiveHandlerdetermines which protocol to use based on the URL scheme and instructs theHTTPDownloaderto download the shard with or without SSL.