Fetch Nav fallbacks and side load resulting entity into state #50126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
commented
Apr 27, 2023
|
|
||
| const record = fallback?._embedded?.self; | ||
|
|
||
| if ( record ) { |
There was a problem hiding this comment.
I added a debugger here after the receiveEntityRecords call and then switched to console and ran:
wp.data.select('core').getEntityRecord('postType', 'wp_navigation', %%THE_ID%%)
...and the record is in state.
So why - with this non-Core data approach - do we get a 2nd network request coming from:
There was a problem hiding this comment.
Consider calling
dispatch.finishResolution( 'getEntityRecord', [
'postType',
'wp_navigation',
fallback?.id,
] );
|
Size Change: +102 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
We went with #50032 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative to #50032 resulting from suggestions by @draganescu
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast