Make Navigation specific Core Data selectors Private #50372
Labels
[Block] Navigation
Affects the Navigation Block
[Type] Code Quality
Issues or PRs that relate to code quality
As suggested in the discussion below, let's make the new Navigation-specific selectors added to Core Data private APIs.
I don't think this is an Issue. What you describe is already working today. It's implemented in this PR and the spin off PoC I created. To be clear here is the code:
This is the point of contention. I don't think it's a major problem to have this selector.
@draganescu In the interests of moving forward would you be open to making it a private selector and then make it public only if/when we confirm that other areas will also require it (for example the
Navigation
section in the Site View sidebar). We get many benefits by using Core Data here and there are also already many examples of the same pattern in use within Core Data.Originally posted by @getdave in #50032 (comment)
The text was updated successfully, but these errors were encountered: