Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation: Remove unnecessary 'role' attribute #41360

Merged
merged 1 commit into from
May 26, 2022
Merged

Navigation: Remove unnecessary 'role' attribute #41360

merged 1 commit into from
May 26, 2022

Conversation

Mamaduka
Copy link
Member

What?

Resolves #41350.

PR removes the unnecessary 'role' attribute for the nav element.

Why?

According to MDN:

Using the <nav> element will automatically communicate a section has a role of navigation. If at all possible, prefer using it instead.

Testing Instructions

Using the TT2 theme open page with a Navigation block, confirm that the role attribute is removed.

@Mamaduka Mamaduka requested a review from ajitbohra as a code owner May 26, 2022 05:44
@Mamaduka Mamaduka requested review from JustinyAhin and aristath May 26, 2022 05:44
@Mamaduka Mamaduka self-assigned this May 26, 2022
@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Block] Navigation Affects the Navigation Block labels May 26, 2022
aristath
aristath approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for this PR! 👍

@Mamaduka Mamaduka merged commit d605788 into trunk May 26, 2022
@Mamaduka Mamaduka deleted the remove/nav-landmark-role branch May 26, 2022 06:35
@github-actions github-actions bot added this to the Gutenberg 13.4 milestone May 26, 2022
youknowriad pushed a commit that referenced this pull request May 26, 2022
@Mamaduka @youknowriad
Navigation: Remove unnecessary 'role' attribute (#41360)
dabe5ea
youknowriad pushed a commit that referenced this pull request Jun 3, 2022
@Mamaduka @youknowriad
Navigation: Remove unnecessary 'role' attribute (#41360)
ceeefe3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristath aristath aristath approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@JustinyAhin JustinyAhin Awaiting requested review from JustinyAhin

Assignees

@Mamaduka Mamaduka

Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 13.4
Development

Successfully merging this pull request may close these issues.

The role="navigation" on the query pagination nav tag is redundant
2 participants
@Mamaduka @aristath