Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The role="navigation" on the query pagination nav tag is redundant #41350

Closed
huubl opened this issue May 25, 2022 · 0 comments · Fixed by #41360
Closed

The role="navigation" on the query pagination nav tag is redundant #41350

huubl opened this issue May 25, 2022 · 0 comments · Fixed by #41360
Assignees
@Mamaduka
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.

Comments

@huubl
Copy link
Contributor

huubl commented May 25, 2022 •
edited
Loading

Description

The role="navigation" on pagination nav tag is unnecessary according to the W3C validator.

Consider removing this line:
https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/query-pagination/index.php#L23

Step-by-step reproduction instructions

  1. https://validator.w3.org/nu/?doc=https%3A%2F%2Fwp-themes.com%2Ftwentytwentytwo%2F%3Fs%3D

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@Mamaduka Mamaduka added [Type] Code Quality Issues or PRs that relate to code quality [Block] Navigation Affects the Navigation Block labels May 25, 2022
@Mamaduka Mamaduka mentioned this issue May 26, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 26, 2022
@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. and removed [Type] Code Quality Issues or PRs that relate to code quality labels May 26, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mamaduka Mamaduka

Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Navigation: Remove unnecessary 'role' attribute WordPress/gutenberg
3 participants
@Mamaduka @priethor @huubl