Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

794 datetime frame #859

Merged
merged 5 commits into from
Oct 31, 2024
Merged

794 datetime frame #859

merged 5 commits into from
Oct 31, 2024

Conversation

erinz2020
Copy link
Contributor

@erinz2020 erinz2020 commented Oct 31, 2024 •
edited
Loading

  1. Encounter Date is a required field and displays the asterisk (*)
  2. If a user tries to submit with an empty Encounter Date field, it throws error
  3. If user enters an invalid datetime, it throws error
  4. Date and Time from EXIF populates with the date/time metadata extracted from the uploaded images
  5. Selecting a Date and Time from EXIF populates the Encounter Date field with the selected information

PR fixes #794

@erinz2020 erinz2020 self-assigned this Oct 31, 2024
@TanyaStere42 TanyaStere42 linked an issue Oct 31, 2024 that may be closed by this pull request
date and time frame #794
Closed
TanyaStere42
TanyaStere42 requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@TanyaStere42 TanyaStere42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "Please" from the error notification across all languages

TanyaStere42
TanyaStere42 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@TanyaStere42 TanyaStere42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look great

@TanyaStere42 TanyaStere42 merged commit 1b5fe0e into submission_page Oct 31, 2024
1 check passed
@TanyaStere42 TanyaStere42 deleted the 794_datetime_frame branch October 31, 2024 19:27
Rodhlann pushed a commit to Rodhlann/Wildbook that referenced this pull request Dec 6, 2024
@TanyaStere42
Merge pull request WildMeOrg#859 from WildMeOrg/794_datetime_frame
bee9297 
794 datetime frame
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TanyaStere42 TanyaStere42 TanyaStere42 approved these changes

@naknomum naknomum Awaiting requested review from naknomum

Assignees

@erinz2020 erinz2020

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

date and time frame
2 participants
@erinz2020 @TanyaStere42