Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all "Watch from here" to "Access from here" #2484

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Change all "Watch from here" to "Access from here" #2484

merged 2 commits into from
Dec 1, 2022

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Nov 3, 2022 •
edited
Loading

"Access from here"

Change "Watch..." to "Access..." because not all content is video.

Also, the controller can't distinguish between the two without creating a new PBCorePresenter for each search result.

Closes #2452

@mrharpo mrharpo requested a review from afred November 3, 2022 21:44
@mrharpo mrharpo self-assigned this Nov 3, 2022
afred
afred approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afred afred merged commit a0d4474 into master Dec 1, 2022
@afred afred deleted the MLAAAPB-52-access-from-here branch December 1, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afred afred afred approved these changes

Assignees

@mrharpo mrharpo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change "Watch from Here" to "Access from Here"
2 participants
@mrharpo @afred