-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "Watch from Here" to "Access from Here" #2452
Comments
@caseyedavis12 It looks like the code already does this, at least a little:
And in snippet_helper.rb, it renders: <button type="button" class="btn btn-default snippet-link">#{media_type == 'Moving Image' ? "Watch" : "Listen"} from here</button> |
Hmmm... here is an example of a radio series where the button says "Watch from Here" |
Very strange! Here is that record you found: But the <instantiationMediaType>Sound</instantiationMediaType> |
It looks like the AAPB2/app/controllers/snippets_controller.rb Lines 36 to 46 in 0a3882b
|
@mrharpo you're right, it'll always get set to 'Moving Image' - I think this is an oversight from my last refactor 😬 if you wanted to maintain the old behavior for this, you would need to get the xml from the SolrDocument, use it to instantiate a I think casey's change to 'Access' is better here, because there's actually a lot of processing and loading that happens during |
User Story
As a user, when I do a search of the AAPB and the keywords appear in a transcript, I should see a link that says "Access from Here" rather than "Watch from Here" since not all content in the AAPB is TV.
The text was updated successfully, but these errors were encountered: