moved tests from tst_h_atts2 into tst_xplatform2, fixed warnings and some memory issues #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edhartnett
commented
Oct 26, 2017
| @@ -209,16 +210,16 @@ check_file_3(int ncid, struct s3 *data_out) | |||
| for (i = 0; i < DIM3_LEN; i++) | |||
| for (j = 0; j < NUM_VL; j++) | |||
| { | |||
| if (data_in[i].data[j].len != data_in[i].data[j].len) ERR; | |||
| if (data_in[i].data[j].len != data_out[i].data[j].len) ERR; | |||
There was a problem hiding this comment.
This is an important warning fix. We were comparing data_in to data_in, which of course was always equal. We need to compare data_in to data_out to actually test results of read.
| /* nc_free_vlen(&(data_in[i].data[j])); */ | ||
| for (i = 0; i < DIM3_LEN; i++) | ||
| for (j = 0; j < NUM_VL; j++) | ||
| nc_free_vlen(&(data_in[i].data[j])); |
There was a problem hiding this comment.
These lines are necessary to free data_in vlens.
| /* How does it look? */ | ||
| if (check_file_3(ncid, comp_array_of_vlen_of_comp_out)) ERR; | ||
| /* How does it look? Uncomment this line to see memory issue. */ | ||
| /* if (check_file_3(ncid, comp_array_of_vlen_of_comp_out)) ERR; */ |
There was a problem hiding this comment.
If this line is uncommented, and the code built with address santizer, then a memory problem is revealed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #542.
Part of #541.
As discussed yesterday with Ward and Denis, there was a dependancy between these files. tst_h_atts2 needed tst_xplatform2 to run first, because it uses HDF5 to check the output of that test. Instead I have moved that output checking to the end of tst_xplatform2 and removed tst_h_atts2.
Also have fixed warnings in tst_xplatform2.
Also have fixed some memory problems in tst_xplatform2. Some remain (see #541). The line of test code that causes this memory issue is left commented out in this test until I can fix that memory problem.