Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tst_h_atts2.c depends on output from tst_xplatform2.c #542

Closed
edhartnett opened this issue Oct 25, 2017 · 5 comments · Fixed by #544
Closed

tst_h_atts2.c depends on output from tst_xplatform2.c #542

edhartnett opened this issue Oct 25, 2017 · 5 comments · Fixed by #544

Comments

@edhartnett
Copy link
Contributor

The test tst_h_atts2.c uses pure HDF5 to confirm the contents of tst_xplatform2.c.

Instead, it would be better to just run these (few) tests at the end of tst_xplatform2.c, eliminating the dependency between these two files.

Ward, are you OK with that? I have the new tst_xplatform2.c working fine with the tests from tst_h_atts2.c, the next step is to remove tst_h_atts2.c and also remove it from Makefile.am and CMakelists.txt.

Sound OK?

@WardF
Copy link
Member

WardF commented Oct 25, 2017

On paper it sounds good, give me a few to go review the file first. Also, any thoughts @DennisHeimbigner

@DennisHeimbigner
Copy link
Collaborator

Sounds like a good idea to me.

@edhartnett
Copy link
Contributor Author

OK, after current backlog has gone through the pipeline, I will submit a PR...

@WardF
Copy link
Member

WardF commented Oct 25, 2017

Testing the current multi-merge right now; it passed Travis. Hoping/assuming that that will be good enough and that the individual PR's won't need to pass as well. We will see.

@edhartnett
Copy link
Contributor Author

Thanks Ward! I have a PR up now which will close this ticket...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants