-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tst_h_atts2.c depends on output from tst_xplatform2.c #542
Comments
On paper it sounds good, give me a few to go review the file first. Also, any thoughts @DennisHeimbigner |
Sounds like a good idea to me. |
OK, after current backlog has gone through the pipeline, I will submit a PR... |
Testing the current multi-merge right now; it passed Travis. Hoping/assuming that that will be good enough and that the individual PR's won't need to pass as well. We will see. |
Thanks Ward! I have a PR up now which will close this ticket... |
The test tst_h_atts2.c uses pure HDF5 to confirm the contents of tst_xplatform2.c.
Instead, it would be better to just run these (few) tests at the end of tst_xplatform2.c, eliminating the dependency between these two files.
Ward, are you OK with that? I have the new tst_xplatform2.c working fine with the tests from tst_h_atts2.c, the next step is to remove tst_h_atts2.c and also remove it from Makefile.am and CMakelists.txt.
Sound OK?
The text was updated successfully, but these errors were encountered: