-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec ecosystem incentive #225
Spec ecosystem incentive #225
Conversation
…e_store and module name
SetHooks usage in app.go: Line 461 in a9f86eb
Line 555 in a9f86eb
The location to define Line 57 in a9f86eb
|
|
||
```protobuf | ||
message FrontendReward { | ||
message Reward { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taiki1frsy
I think the data structure is ambiguous.
Can I see a sample data structure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkXultra
I added description in 02_state.md for more abundant document of the data structures in this module.
Plz refer.
It might be better to have a Keeper Method that punishes it if there is a malicious front end. |
|
Memo: |
This PR is for the revision of the previous frontend-incentive module specification after the research about the things on check_list in there.
This PR is merged into the PR #216 . After merged, that PR also is merged into
design/spec
branch manually.The changed parts from the previous frontend-incentive specification are not a few actually.
About module name
I changed module name from frontend-incentive to ecosystem-incentive because the current style can be applied for many different use-cases by using the same logic.
About logic
The biggest modification is definitely hooks part.
As you know, in the previous design, we planed to use event data for catching the traded fee information to accumulate rewards for the subjects.
But, after the research about it, it turned out to be impossible to do so.
Instead, there're hooks mechanism for cosmos sdk for literally hooking to some target actions.
(research log: https://www.notion.so/cauchye/Frontend-incentive-Tech-research-9b0965c91cd542ecbb6ea123d557add3)
By using this mechanism and the way to get memo data in a specific message process in the how_get_memo branch, we can implement incentive features without generating two-way dependencies between x/nftmarket and x/ecosystem-incentive modules.
And, following these changes, I decided to accept register style to become subject.
refs:
#218
https://www.notion.so/cauchye/Frontend-incentive-Tech-research-9b0965c91cd542ecbb6ea123d557add3
Please review and confirm, @mkXultra .