-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address Issue 27 - Selective processing and uploading of articles and collections mentioned in the command-line argument #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add code to filter and process only the collections whose IDs are explicitly provided via the command-line argument.
1. Add code to filter and process only the articles whose IDs are explicitly provided 2. Create a variable to indicate whether article IDs have been explicitly passed or not. The value 'True' signifies explicit inclusion.
1. Add code to capture curation folder names for the articles that have been matched. 2. If a curation folder exists for a matched article, the folder name is stored in the 'self.matched_curation_folder_list' variable. 3. This variable is used in a later stage of the code (in process_articles function) when article IDs are explicitly passed and the curation folder size is calculated based on the matched curation folders.
Currently, the required space is calculated by summing the curation folder size and the total size of all articles. The curation folder size is determined by considering all curation folders. However, when article IDs are provided explicitly, it is unnecessary to consider all curation folders. Instead, only the curation folder(s) that match the provided article ID(s) should be considered for calculating the 'curation folder size'. This refinement enables a more accurate calculation of the required space. The code responsible for this functionality has been developed and committed as part of this commit
… size, and required space Add log messages for tracking total size of articles, curation folder size, and required space
Implement code to count and display matched and unmatched article IDs after performing the curation folder check for articles.
1. The parameter 'total_file_size' passed to the function '__initial_process' has been removed since it is not utilized within the function. 2. To prevent errors when the values for 'matched_articles' and 'unmatched_articles' variables are empty, their declarations have been adjusted. 3. Lint errors have been fixed
Fix lint errors
fix lint errors
fix lint errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request must be merged after pull request #44 to avoid errors during code execution. If this order is not followed, an error will be thrown.
Please find below the list of functionalities that have been accomplished through the code added in this pull request.
Please refer to the commits titled 'Add processing and upload of collections based on IDs' and 'Add processing and upload of articles based on IDs' to see the precise details of the added code and its specific location.
Please refer to the commits titled 'Capture curation folder names for matched articles' and 'Calculate curation folder size based on matched curation folders' to see the precise details of the added code and its specific location.
Please refer to the commits titled 'Add code to count and display matched and unmatched article Ids' and 'Add log messages for tracking total size of articles, curation folder size, and required space' to see the precise details of the added code and its specific location.