Address Issue 43 - Enhance ReBACH to accept specific article and collection IDs for selective processing #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arguments 1. Implement a new function to retrieve the list of article and collection IDs from command-line arguments. 2. When the number of command-line arguments exceeds 2, the function extracts the argument string specifically representing the list of IDs. 3. Convert the argument string into a Python list 4. Return list of IDs
…d collections IDs Add the command-line argument '--Ids' to specify specific article and collection IDs for processing.
|
By merging this PR, the code will not break. However, this code should remain in draft until the argument parsing is done using the proper library (see the bagger implementation). |
pavithraarizona
changed the title
Fix lint errors
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request must be merged before pull request #45.
This pull request contains the code that implements the functionality mentioned in issue #43.
As part of this pull request, two files are modified. Please find below file names
'bagger/config/init.py' - Added code to parse command line argument '--Ids'
figshare/Integration.py - A new function is added to extract article and collection IDs from command-line argument
Information about file: 'bagger/config/init.py'
As mentioned above, currently, the parsing of command line argument '--Ids' is done in the 'bagger/config/init.py' file.
To see the exact location where it is parsed in the 'bagger/config/init.py' file, please refer to the following link:
ReBACH/bagger/config/__init__.py
Line 71 in 2da8075
However, it is necessary to enhance this code in the future to parse the '--Ids' argument from the 'app.py' file, as it is the correct approach."
-> a new function named 'get_id_list' is added in this file.
-> This function retrieve the list of article and collection IDs from command-line arguments.
-> When the number of command-line arguments exceeds 2, the function checks whether there is an argument with the name '--Ids'. If such an argument exists, the function extracts the argument string that specifically represents the list of IDs.
-> The function returns the extracted list of IDs.
Please find below places where function 'get_id_list' is called
ReBACH/figshare/Article.py
Line 86 in c5a1a98
ReBACH/figshare/Collection.py
Line 66 in c5a1a98