-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change item select to press instead of release (click) #556
Change item select to press instead of release (click) #556
Conversation
@Roc25 seems to work fine in my testing.
i couldn't find any global settings menu, though there seems to be an ini file in |
I quickly wrote a simple setting, if it’s approved I’ll refactor it later. It's a checkbox in "window" dropdown menu on top (idk what it's called). At this moment it has some bugs |
@Roc25 even though it stays selected after a restart it needs to be turned off and on again to actually work. |
@VasigaranAndAngel was last working on a settings menu implementation - this was hopefully coming in #515 however due to the urgency of such a feature I think it might be best to go forward with one ourselves. The .ini/QSettings file is intended for application-wide settings, while library-specific preferences should be stored separately. There was a sizable thread in the discord about potential settings implementations, but mostly from a backend perspective. For the UI I would image things just read from the TOML-formatted .ini/.plist file into a tab-organized window. I'll draft up a feature request for this to better organize this and facilitate further discussion and feedback |
Personally, I don't feel this feature needs a settings option. It's a small implementation detail that most users won't notice or see a need to change the behavior of. It also introduces unnecessary code duplication checking whether .press or .click should be called. |
After testing I think this should just be the default and only behavior. Windows Explorer, Finder, and at least some Linux file explorer(s) (Dolphin confirmed) all have "select on mouse down" behavior. |
65be5c0
to
cc61e18
Compare
Squashed several commits |
For #555. I think it's better to add this to the settings, but leave it as default