Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change item select to press instead of release (click) #556

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

Roc25
Copy link
Contributor

@Roc25 Roc25 commented Oct 20, 2024

For #555. I think it's better to add this to the settings, but leave it as default

@BPplays
Copy link
Contributor

BPplays commented Oct 21, 2024

@Roc25 seems to work fine in my testing.
⁤⁤

I think it's better to add this to the settings

i couldn't find any global settings menu, though there seems to be an ini file in %appdata%\TagStudio on windows.
i think some discussion on what the settings menu should look like probably needs to happen first,
@CyanVoxel are there any plans for how the options menu should look?

@Roc25
Copy link
Contributor Author

Roc25 commented Oct 22, 2024

I quickly wrote a simple setting, if it’s approved I’ll refactor it later. It's a checkbox in "window" dropdown menu on top (idk what it's called). At this moment it has some bugs

@Roc25 Roc25 marked this pull request as draft October 22, 2024 07:13
@BPplays
Copy link
Contributor

BPplays commented Oct 24, 2024

@Roc25 even though it stays selected after a restart it needs to be turned off and on again to actually work.
also i feel like it should be select on press by default and release should be opt-in.

@CyanVoxel
Copy link
Member

i couldn't find any global settings menu, though there seems to be an ini file in %appdata%\TagStudio on windows. i think some discussion on what the settings menu should look like probably needs to happen first, @CyanVoxel are there any plans for how the options menu should look?

@VasigaranAndAngel was last working on a settings menu implementation - this was hopefully coming in #515 however due to the urgency of such a feature I think it might be best to go forward with one ourselves.

The .ini/QSettings file is intended for application-wide settings, while library-specific preferences should be stored separately. There was a sizable thread in the discord about potential settings implementations, but mostly from a backend perspective. For the UI I would image things just read from the TOML-formatted .ini/.plist file into a tab-organized window. I'll draft up a feature request for this to better organize this and facilitate further discussion and feedback

@seakrueger
Copy link
Collaborator

Personally, I don't feel this feature needs a settings option. It's a small implementation detail that most users won't notice or see a need to change the behavior of. It also introduces unnecessary code duplication checking whether .press or .click should be called.

@CyanVoxel
Copy link
Member

After testing I think this should just be the default and only behavior. Windows Explorer, Finder, and at least some Linux file explorer(s) (Dolphin confirmed) all have "select on mouse down" behavior.

@CyanVoxel CyanVoxel added the Type: Enhancement New feature or request label Oct 26, 2024
@Roc25 Roc25 marked this pull request as ready for review October 26, 2024 10:11
@Roc25 Roc25 force-pushed the press-select-instead-release branch from 65be5c0 to cc61e18 Compare October 26, 2024 10:17
@Roc25
Copy link
Contributor Author

Roc25 commented Oct 26, 2024

Squashed several commits

@CyanVoxel CyanVoxel added Type: UI/UX User interface and/or user experience Status: Review Needed A review of this is needed labels Nov 4, 2024
@CyanVoxel CyanVoxel added this to the Alpha v9.5 (Post-SQL) milestone Nov 4, 2024
@CyanVoxel CyanVoxel added the Priority: Medium An issue that shouldn't be be saved for last label Nov 9, 2024
@CyanVoxel CyanVoxel removed the Status: Review Needed A review of this is needed label Nov 18, 2024
@CyanVoxel CyanVoxel linked an issue Nov 18, 2024 that may be closed by this pull request
3 tasks
@CyanVoxel CyanVoxel merged commit 2977e07 into TagStudioDev:main Nov 18, 2024
5 checks passed
CyanVoxel added a commit that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium An issue that shouldn't be be saved for last Type: Enhancement New feature or request Type: UI/UX User interface and/or user experience
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Feature Request]: change images on pressing the mouse instead of on releasing
4 participants