Change behavior to 'on mouse down'

TagStudioDev · Oct 26, 2024 · 65be5c0 · 65be5c0
1 parent caa481d
commit 65be5c0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 36 deletions.
diff --git a/tagstudio/src/core/enums.py b/tagstudio/src/core/enums.py
@@ -11,7 +11,6 @@ class SettingItems(str, enum.Enum):
     LIBS_LIST = "libs_list"
     WINDOW_SHOW_LIBS = "window_show_libs"
     AUTOPLAY = "autoplay_videos"
-    ITEM_SELECT_ON_PRESS = "item_select_on_press"
 
 
 class Theme(str, enum.Enum):

diff --git a/tagstudio/src/qt/ts_qt.py b/tagstudio/src/qt/ts_qt.py
@@ -421,23 +421,6 @@ def create_dupe_files_modal():
         )
         window_menu.addAction(show_libs_list_action)
 
-        item_select_on_press = QAction("Select thumb on press", menu_bar)
-        item_select_on_press.setCheckable(True)
-        item_select_on_press.setChecked(
-            bool(
-                self.settings.value(
-                    SettingItems.ITEM_SELECT_ON_PRESS, defaultValue=False, type=bool
-                )
-            )
-        )
-        item_select_on_press.triggered.connect(
-            lambda checked: (
-                self.settings.setValue(SettingItems.ITEM_SELECT_ON_PRESS, checked),
-                self.update_thumbs(),
-            )
-        )
-        window_menu.addAction(item_select_on_press)
-
         def create_folders_tags_modal():
             if not hasattr(self, "folders_modal"):
                 self.folders_modal = FoldersToTagsModal(self.lib, self)

diff --git a/tagstudio/src/qt/widgets/item_thumb.py b/tagstudio/src/qt/widgets/item_thumb.py
@@ -24,7 +24,6 @@
     TAG_ARCHIVED,
     TAG_FAVORITE,
 )
-from src.core.enums import SettingItems
 from src.core.library import Entry, ItemType, Library
 from src.core.library.alchemy.enums import FilterState
 from src.core.library.alchemy.fields import _FieldID
@@ -381,24 +380,11 @@ def update_size(self, timestamp: float, size: QSize):
 
     def update_clickable(self, clickable: typing.Callable):
         """Updates attributes of a thumbnail element."""
-        is_select_on_press = self.driver.settings.value(SettingItems.ITEM_SELECT_ON_PRESS)
-        if is_select_on_press:
-            self.thumb_button.clicked.disconnect()
-            self.thumb_button.clicked.disconnect()
-
-            if self.thumb_button.is_connected:
-                self.thumb_button.pressed.disconnect()
-            if clickable:
-                self.thumb_button.pressed.connect(clickable)
-                self.thumb_button.is_connected = True
-        else:
-            self.thumb_button.pressed.disconnect()
+        if self.thumb_button.is_connected:
             self.thumb_button.pressed.disconnect()
-            if self.thumb_button.is_connected:
-                self.thumb_button.clicked.disconnect()
-            if clickable:
-                self.thumb_button.clicked.connect(clickable)
-                self.thumb_button.is_connected = True
+        if clickable:
+            self.thumb_button.pressed.connect(clickable)
+            self.thumb_button.is_connected = True
 
     def refresh_badge(self, entry: Entry | None = None):
         if not entry: