Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve parser regex for MSVC 14.11 #1356

Merged
merged 2 commits into from
Dec 19, 2017
Merged

improve parser regex for MSVC 14.11 #1356

merged 2 commits into from
Dec 19, 2017

Conversation

Bertk
Copy link
Contributor

@Bertk Bertk commented Dec 18, 2017 •
edited by SonarOpenCommunityAdmin
Loading

related #1325

This change is Reviewable

@guwirth guwirth added this to the 0.9.9 milestone Dec 18, 2017
guwirth
guwirth reviewed Dec 18, 2017
View reviewed changes
Copy link
Collaborator

@guwirth guwirth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bertk are there also different versions from ParallelBuildLog.txt available? Seems is always the latest?

@Bertk
Copy link
Contributor Author

Bertk commented Dec 18, 2017

@guwirth I added a parallel build log file and this makes currently no difference for the configuration. This might have an impact on parsing the warning messages (compiler sensor).
The parser should be improved for multi module parsing.

@guwirth
Copy link
Collaborator

guwirth commented Dec 19, 2017 •
edited
Loading

@Bertk ready to merge?

@Bertk
Copy link
Contributor Author

Bertk commented Dec 19, 2017

@guwirth Yes 👍

@guwirth guwirth merged commit d397e9d into SonarOpenCommunity:master Dec 19, 2017
@Bertk Bertk deleted the performance branch December 20, 2017 07:30
@guwirth guwirth mentioned this pull request Jan 6, 2018
Closed
@Bertk Bertk mentioned this pull request Mar 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guwirth guwirth guwirth approved these changes

Assignees

@Bertk Bertk

Labels
enhancement
Milestone
0.9.9
Development

Successfully merging this pull request may close these issues.
2 participants
@Bertk @guwirth