Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: cleanup CxxSquidSensor - remove CxxVCppBuildLogParser #1325

Closed
guwirth opened this issue Nov 20, 2017 · 2 comments · Fixed by #1970
Closed

Refactoring: cleanup CxxSquidSensor - remove CxxVCppBuildLogParser #1325

guwirth opened this issue Nov 20, 2017 · 2 comments · Fixed by #1970
Assignees
@guwirth
Labels
enhancement
Milestone
2.0.0

Comments

@guwirth
Copy link
Collaborator

guwirth commented Nov 20, 2017

Remove CxxVCppBuildLogParser call from CxxSquidSensor: cxxConf.setCompilationPropertiesWithBuildLog in createConfiguration.

This is slowing down the plugin because CxxSquidSensor is called for each source file. CxxVCppBuildLogParser should be called only once and save parsed setting at a central place e.g. CxxConfiguration.
@guwirth guwirth added this to the 0.9.9 milestone Nov 20, 2017
This was referenced Nov 20, 2017
Closed
Closed
@Bertk
Copy link
Contributor

Bertk commented Dec 18, 2017

I checked the behavior and the log file parser is called once per module (per VC++ project) which is correct.

2017-12-18T07:12:00.8478356Z INFO: build log parser baseDir='C:\agent\_work\1\s\Source\SQCxxTestData'
2017-12-18T07:12:00.9572044Z INFO: Parse build log 'C:\agent\_work\1\s\CppTesting.sln.log' added includes: '16', added defines: '16'
2017-12-18T07:12:04.3476589Z INFO: build log parser baseDir='C:\agent\_work\1\s\Source\MotorController'
2017-12-18T07:12:04.4570271Z INFO: Parse build log 'C:\agent\_work\1\s\CppTesting.sln.log' added includes: '16', added defines: '16'
2017-12-18T07:12:23.2740779Z INFO: build log parser baseDir='C:\agent\_work\1\s\Source\RootFinder'
2017-12-18T07:12:23.3834404Z INFO: Parse build log 'C:\agent\_work\1\s\CppTesting.sln.log' added includes: '16', added defines: '16'
2017-12-18T07:12:42.4299502Z INFO: build log parser baseDir='C:\agent\_work\1\s\Source\Calculation'
2017-12-18T07:12:42.5393214Z INFO: Parse build log 'C:\agent\_work\1\s\CppTesting.sln.log' added includes: '16', added defines: '16'

The parser will analyze each line of the log file which has a performance impact for large multi module log files and may also create wrong settings because the parser does not handle the module settings separately e.g. it consumes all include paths or preprocessor definitions.

sample log file parser results

12:24:22.091 DEBUG org.sonar.cxx.CxxVCppBuildLogParser - build log parser baseDir='.'
12:24:22.107 DEBUG org.sonar.cxx.CxxVCppBuildLogParser - build log parser cl.exe line='2017-12-18T08:06:51.9532303Z   C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\CL.exe /c /IC:\agent\_work\1\s\_Globals\Include /ZI /nologo /W4 /WX- /diagnostics:classic /Od /Oy- /D CODE_ANALYSIS /D WIN32 /D _DEBUG /D _WINDOWS /D _USRDLL /D CROOTFINDER_EXPORTS /D _WINDLL /D _UNICODE /D UNICODE /Gm /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Yc"stdafx.h" /Fp"Debug\RootFinder.pch" /Fo"Debug\\" /Fd"Debug\vc141.pdb" /Gd /TP /analyze /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\\bin\HostX86\x86\EspXEngine.dll" /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\localespc.dll" /FC /errorReport:queue   /analyze:quiet stdafx.cpp'
12:24:22.107 DEBUG org.sonar.cxx.CxxVCppBuildLogParser - build log parser cl.exe line='2017-12-18T08:06:53.9219713Z   C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\CL.exe /c /IC:\agent\_work\1\s\_Globals\Include /ZI /nologo /W4 /WX- /diagnostics:classic /Od /Oy- /D CODE_ANALYSIS /D WIN32 /D _DEBUG /D _WINDOWS /D _USRDLL /D CROOTFINDER_EXPORTS /D _WINDLL /D _UNICODE /D UNICODE /Gm /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"Debug\\" /Fd"Debug\vc141.pdb" /Gd /TP /analyze /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\\bin\HostX86\x86\EspXEngine.dll" /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\localespc.dll" /FC /errorReport:queue   /analyze:quiet dllmain.cpp'
12:24:22.107 DEBUG org.sonar.cxx.CxxVCppBuildLogParser - build log parser cl.exe line='2017-12-18T08:06:55.9532193Z   C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\CL.exe /c /IC:\agent\_work\1\s\_Globals\Include /ZI /nologo /W4 /WX- /diagnostics:classic /Od /Oy- /D CODE_ANALYSIS /D WIN32 /D _DEBUG /D _WINDOWS /D _USRDLL /D CROOTFINDER_EXPORTS /D _WINDLL /D _UNICODE /D UNICODE /Gm /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Yu"stdafx.h" /Fp"Debug\RootFinder.pch" /Fo"Debug\\" /Fd"Debug\vc141.pdb" /Gd /TP /analyze /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\\bin\HostX86\x86\EspXEngine.dll" /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\localespc.dll" /FC /errorReport:queue   /analyze:quiet RootFinder.cpp'
12:24:22.122 DEBUG org.sonar.cxx.CxxVCppBuildLogParser - build log parser cl.exe line='2017-12-18T08:06:58.9219814Z   C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\CL.exe /c /IC:\agent\_work\1\s\_Globals\Include /ZI /nologo /W4 /WX- /diagnostics:classic /Od /Oy- /D CODE_ANALYSIS /D WIN32 /D _DEBUG /D _WINDOWS /D _USRDLL /D MOTORCONTROLLER_EXPORTS /D _WINDLL /D _UNICODE /D UNICODE /Gm /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Yc"stdafx.h" /Fp"Debug\MotorController.pch" /Fo"Debug\\" /Fd"Debug\vc141.pdb" /Gd /TP /analyze /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\\bin\HostX86\x86\EspXEngine.dll" /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\localespc.dll" /FC /errorReport:queue   /analyze:quiet stdafx.cpp'
12:24:22.122 DEBUG org.sonar.cxx.CxxVCppBuildLogParser - build log parser cl.exe line='2017-12-18T08:07:00.8438422Z   C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\CL.exe /c /IC:\agent\_work\1\s\_Globals\Include /ZI /nologo /W4 /WX- /diagnostics:classic /Od /Oy- /D CODE_ANALYSIS /D WIN32 /D _DEBUG /D _WINDOWS /D _USRDLL /D MOTORCONTROLLER_EXPORTS /D _WINDLL /D _UNICODE /D UNICODE /Gm /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"Debug\\" /Fd"Debug\vc141.pdb" /Gd /TP /analyze /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\\bin\HostX86\x86\EspXEngine.dll" /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\localespc.dll" /FC /errorReport:queue   /analyze:quiet dllmain.cpp'
12:24:22.138 DEBUG org.sonar.cxx.CxxVCppBuildLogParser - build log parser cl.exe line='2017-12-18T08:07:02.7032195Z   C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\CL.exe /c /IC:\agent\_work\1\s\_Globals\Include /ZI /nologo /W4 /WX- /diagnostics:classic /Od /Oy- /D CODE_ANALYSIS /D WIN32 /D _DEBUG /D _WINDOWS /D _USRDLL /D MOTORCONTROLLER_EXPORTS /D _WINDLL /D _UNICODE /D UNICODE /Gm /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Yu"stdafx.h" /Fp"Debug\MotorController.pch" /Fo"Debug\\" /Fd"Debug\vc141.pdb" /Gd /TP /analyze /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\\bin\HostX86\x86\EspXEngine.dll" /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\localespc.dll" /FC /errorReport:queue   /analyze:quiet MotorController.cpp'
12:24:22.138 DEBUG org.sonar.cxx.CxxVCppBuildLogParser - build log parser cl.exe line='2017-12-18T08:07:03.5242681Z   C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\CL.exe /c /ZI /nologo /W4 /WX- /diagnostics:classic /Od /Oy- /D CODE_ANALYSIS /D WIN32 /D _DEBUG /D _WINDLL /D _UNICODE /D UNICODE /Gm /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Yc"stdafx.h" /Fp"Debug\MotorControllerTests.pch" /Fo"Debug\\" /Fd"Debug\vc141.pdb" /Gd /TP /analyze /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\localespc.dll" /FC /errorReport:queue   /analyze:quiet stdafx.cpp'
12:24:22.138 DEBUG org.sonar.cxx.CxxVCppBuildLogParser - build log parser cl.exe line='2017-12-18T08:07:08.3373308Z   C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\CL.exe /c /ZI /nologo /W4 /WX- /diagnostics:classic /Od /Oy- /D CODE_ANALYSIS /D WIN32 /D _DEBUG /D _WINDLL /D _UNICODE /D UNICODE /Gm /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Yu"stdafx.h" /Fp"Debug\MotorControllerTests.pch" /Fo"Debug\\" /Fd"Debug\vc141.pdb" /Gd /TP /analyze /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\localespc.dll" /FC /errorReport:queue   /analyze:quiet unittest1.cpp'
12:24:22.138 DEBUG org.sonar.cxx.CxxVCppBuildLogParser - build log parser cl.exe line='2017-12-18T08:07:09.1568384Z   C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\CL.exe /c /IC:\agent\_work\1\s\_Globals\Include /ZI /nologo /W4 /WX- /diagnostics:classic /Od /Oy- /D CODE_ANALYSIS /D WIN32 /D _DEBUG /D _WINDOWS /D CALCULATION_EXPORTS /D _WINDLL /D _UNICODE /D UNICODE /Gm /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Yc"stdafx.h" /Fp"Debug\Calculation.pch" /Fo"Debug\\" /Fd"Debug\vc141.pdb" /Gd /TP /analyze /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\\bin\HostX86\x86\EspXEngine.dll" /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\localespc.dll" /FC /errorReport:queue   /analyze:quiet stdafx.cpp'
12:24:22.138 DEBUG org.sonar.cxx.CxxVCppBuildLogParser - build log parser cl.exe line='2017-12-18T08:07:10.7505860Z   C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\CL.exe /c /IC:\agent\_work\1\s\_Globals\Include /ZI /nologo /W4 /WX- /diagnostics:classic /Od /Oy- /D CODE_ANALYSIS /D WIN32 /D _DEBUG /D _WINDOWS /D CALCULATION_EXPORTS /D _WINDLL /D _UNICODE /D UNICODE /Gm /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Yu"stdafx.h" /Fp"Debug\Calculation.pch" /Fo"Debug\\" /Fd"Debug\vc141.pdb" /Gd /TP /analyze /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\\bin\HostX86\x86\EspXEngine.dll" /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\localespc.dll" /FC /errorReport:queue   /analyze:quiet Addition.cpp Calculation.cpp Multiply.cpp'
12:24:22.138 DEBUG org.sonar.cxx.CxxVCppBuildLogParser - build log parser cl.exe line='2017-12-18T08:07:12.3107390Z   C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\CL.exe /c /I"C:\agent\_work\1\s\packages\vcpkg-export-20170706-185405.1.0.0\installed\x86-windows\include" /ZI /nologo /W3 /WX- /diagnostics:classic /Od /Oy- /D CODE_ANALYSIS /D WIN32 /D _DEBUG /D _CONSOLE /D _UNICODE /D UNICODE /Gm /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Yc"stdafx.h" /Fp"Debug\CalculationTests.pch" /Fo"Debug\\" /Fd"Debug\vc141.pdb" /Gd /TP /analyze /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\localespc.dll" /errorReport:queue   /analyze:quiet stdafx.cpp'
12:24:22.216 DEBUG org.sonar.cxx.CxxVCppBuildLogParser - build log parser cl.exe line='2017-12-18T08:07:13.3420015Z   C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\CL.exe /c /I"C:\agent\_work\1\s\packages\vcpkg-export-20170706-185405.1.0.0\installed\x86-windows\include" /ZI /nologo /W3 /WX- /diagnostics:classic /Od /Oy- /D CODE_ANALYSIS /D WIN32 /D _DEBUG /D _CONSOLE /D _UNICODE /D UNICODE /Gm /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Yu"stdafx.h" /Fp"Debug\CalculationTests.pch" /Fo"Debug\\" /Fd"Debug\vc141.pdb" /Gd /TP /analyze /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\localespc.dll" /errorReport:queue   /analyze:quiet CalculationTest.cpp Addition_Test.cpp Multiply_Test.cpp'
12:24:22.216 DEBUG org.sonar.cxx.CxxVCppBuildLogParser - build log parser cl.exe line='2017-12-18T08:07:32.5301243Z   C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\CL.exe /c /ZI /nologo /W4 /WX- /diagnostics:classic /Od /Oy- /D CODE_ANALYSIS /D WIN32 /D _DEBUG /D _WINDLL /D _UNICODE /D UNICODE /Gm /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Yc"stdafx.h" /Fp"Debug\RootFinderTests.pch" /Fo"Debug\\" /Fd"Debug\vc141.pdb" /Gd /TP /analyze /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\localespc.dll" /FC /errorReport:queue   /analyze:quiet stdafx.cpp'
12:24:22.216 DEBUG org.sonar.cxx.CxxVCppBuildLogParser - build log parser cl.exe line='2017-12-18T08:07:37.0926688Z   C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\CL.exe /c /ZI /nologo /W4 /WX- /diagnostics:classic /Od /Oy- /D CODE_ANALYSIS /D WIN32 /D _DEBUG /D _WINDLL /D _UNICODE /D UNICODE /Gm /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Yu"stdafx.h" /Fp"Debug\RootFinderTests.pch" /Fo"Debug\\" /Fd"Debug\vc141.pdb" /Gd /TP /analyze /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\localespc.dll" /FC /errorReport:queue   /analyze:quiet unittest1.cpp'
12:24:22.232 DEBUG org.sonar.cxx.CxxVCppBuildLogParser - build log parser cl.exe line='2017-12-18T08:07:37.8131889Z   C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\CL.exe /c /IC:\agent\_work\1\s\_Globals\Include /ZI /nologo /W4 /WX- /diagnostics:classic /Od /Oy- /D CODE_ANALYSIS /D WIN32 /D _DEBUG /D _WINDOWS /D SQTEST_EXPORTS /D _WINDLL /D _UNICODE /D UNICODE /Gm /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"Debug\\" /Fd"Debug\vc141.pdb" /Gd /TP /analyze /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\\bin\HostX86\x86\EspXEngine.dll" /analyze:plugin"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.11.25503\bin\HostX86\x86\localespc.dll" /FC /errorReport:queue   /analyze:quiet component1.cc component2.cc'
12:24:22.263 INFO  org.sonar.cxx.CxxConfiguration - Parse build log 'C:\Github\sonar-cxx\cxx-squid\src\test\resources\logfile\TFS-agent-msvc14.txt' added includes: '9', added defines: '9'
12:24:22.263 DEBUG org.sonar.cxx.CxxConfiguration - Includes folders (2)='[C:\agent\_work\1\s\_Globals\Include, C:\agent\_work\1\s\packages\vcpkg-export-20170706-185405.1.0.0\installed\x86-windows\include]'
12:24:22.263 DEBUG org.sonar.cxx.CxxConfiguration - Includes folders (1)='[C:\agent\_work\1\s\_Globals\Include]'
12:24:22.263 DEBUG org.sonar.cxx.CxxConfiguration - Includes folders (1)='[C:\agent\_work\1\s\_Globals\Include]'
12:24:22.263 DEBUG org.sonar.cxx.CxxConfiguration - Includes folders (1)='[C:\agent\_work\1\s\_Globals\Include]'
12:24:22.263 DEBUG org.sonar.cxx.CxxConfiguration - Includes folders (1)='[C:\agent\_work\1\s\_Globals\Include]'
12:24:22.263 DEBUG org.sonar.cxx.CxxConfiguration - Includes folders (1)='[C:\agent\_work\1\s\_Globals\Include]'
12:24:22.263 DEBUG org.sonar.cxx.CxxConfiguration - Includes folders (1)='[C:\agent\_work\1\s\packages\vcpkg-export-20170706-185405.1.0.0\installed\x86-windows\include]'
12:24:22.263 DEBUG org.sonar.cxx.CxxConfiguration - Defines (33)='[_UNICODE, CALCULATION_EXPORTS, CROOTFINDER_EXPORTS, _MT, MOTORCONTROLLER_EXPORTS, __TIME__ "??:??:??", _MSC_VER 1910, _ATL_VER 0x0E00, __TIMESTAMP__ "??? ?? ???? ??:??:??", CODE_ANALYSIS, UNICODE, _DEBUG, _WIN32, _M_IX86 600, _USRDLL, __FILE__ "file", __cplusplus 199711L, _CPPUNWIND, __DATE__ "??? ?? ????", _WINDLL, _DLL, _CONSOLE, _NATIVE_WCHAR_T_DEFINED 1, _WINDOWS, _WCHAR_T_DEFINED 1, __COUNTER__ 0, _MSC_BUILD 1, _MSC_FULL_VER 191024629, WIN32, _INTEGRAL_MAX_BITS 64, __LINE__ 1, _MFC_VER 0x0E00, _M_IX86_FP 2]'
12:24:22.263 DEBUG org.sonar.cxx.CxxConfiguration - Defines (30)='[_UNICODE, MOTORCONTROLLER_EXPORTS, _MT, __TIME__ "??:??:??", _MSC_VER 1910, _ATL_VER 0x0E00, __TIMESTAMP__ "??? ?? ???? ??:??:??", CODE_ANALYSIS, UNICODE, _DEBUG, _WIN32, _M_IX86 600, _USRDLL, __FILE__ "file", __cplusplus 199711L, _CPPUNWIND, __DATE__ "??? ?? ????", _WINDLL, _DLL, _NATIVE_WCHAR_T_DEFINED 1, _WINDOWS, _WCHAR_T_DEFINED 1, __COUNTER__ 0, _MSC_BUILD 1, _MSC_FULL_VER 191024629, WIN32, _INTEGRAL_MAX_BITS 64, __LINE__ 1, _MFC_VER 0x0E00, _M_IX86_FP 2]'
12:24:22.294 DEBUG org.sonar.cxx.CxxConfiguration - Defines (31)='[_UNICODE, CROOTFINDER_EXPORTS, _MT, MOTORCONTROLLER_EXPORTS, __TIME__ "??:??:??", _MSC_VER 1910, _ATL_VER 0x0E00, __TIMESTAMP__ "??? ?? ???? ??:??:??", CODE_ANALYSIS, UNICODE, _DEBUG, _WIN32, _M_IX86 600, _USRDLL, __FILE__ "file", __cplusplus 199711L, _CPPUNWIND, __DATE__ "??? ?? ????", _WINDLL, _DLL, _NATIVE_WCHAR_T_DEFINED 1, _WINDOWS, _WCHAR_T_DEFINED 1, __COUNTER__ 0, _MSC_BUILD 1, _MSC_FULL_VER 191024629, WIN32, _INTEGRAL_MAX_BITS 64, __LINE__ 1, _MFC_VER 0x0E00, _M_IX86_FP 2]'
12:24:22.294 DEBUG org.sonar.cxx.CxxConfiguration - Defines (30)='[_UNICODE, CROOTFINDER_EXPORTS, _MT, __TIME__ "??:??:??", _MSC_VER 1910, _ATL_VER 0x0E00, __TIMESTAMP__ "??? ?? ???? ??:??:??", CODE_ANALYSIS, UNICODE, _DEBUG, _WIN32, _M_IX86 600, _USRDLL, __FILE__ "file", __cplusplus 199711L, _CPPUNWIND, __DATE__ "??? ?? ????", _WINDLL, _DLL, _NATIVE_WCHAR_T_DEFINED 1, _WINDOWS, _WCHAR_T_DEFINED 1, __COUNTER__ 0, _MSC_BUILD 1, _MSC_FULL_VER 191024629, WIN32, _INTEGRAL_MAX_BITS 64, __LINE__ 1, _MFC_VER 0x0E00, _M_IX86_FP 2]'
12:24:22.294 DEBUG org.sonar.cxx.CxxConfiguration - Defines (29)='[_UNICODE, CALCULATION_EXPORTS, _MT, __TIME__ "??:??:??", _MSC_VER 1910, _ATL_VER 0x0E00, __TIMESTAMP__ "??? ?? ???? ??:??:??", CODE_ANALYSIS, UNICODE, _DEBUG, _WIN32, _M_IX86 600, __FILE__ "file", __cplusplus 199711L, _CPPUNWIND, __DATE__ "??? ?? ????", _WINDLL, _DLL, _NATIVE_WCHAR_T_DEFINED 1, _WINDOWS, _WCHAR_T_DEFINED 1, __COUNTER__ 0, _MSC_BUILD 1, _MSC_FULL_VER 191024629, WIN32, _INTEGRAL_MAX_BITS 64, __LINE__ 1, _MFC_VER 0x0E00, _M_IX86_FP 2]'
12:24:22.294 DEBUG org.sonar.cxx.CxxConfiguration - Defines (29)='[_UNICODE, _MT, __TIME__ "??:??:??", _MSC_VER 1910, _ATL_VER 0x0E00, __TIMESTAMP__ "??? ?? ???? ??:??:??", CODE_ANALYSIS, UNICODE, _DEBUG, _WIN32, _M_IX86 600, __FILE__ "file", __cplusplus 199711L, _CPPUNWIND, __DATE__ "??? ?? ????", _WINDLL, _DLL, _NATIVE_WCHAR_T_DEFINED 1, _WINDOWS, _WCHAR_T_DEFINED 1, __COUNTER__ 0, _MSC_BUILD 1, SQTEST_EXPORTS, _MSC_FULL_VER 191024629, WIN32, _INTEGRAL_MAX_BITS 64, __LINE__ 1, _MFC_VER 0x0E00, _M_IX86_FP 2]'
12:24:22.294 DEBUG org.sonar.cxx.CxxConfiguration - Defines (27)='[_UNICODE, _MT, __TIME__ "??:??:??", _MSC_VER 1910, _ATL_VER 0x0E00, __TIMESTAMP__ "??? ?? ???? ??:??:??", CODE_ANALYSIS, UNICODE, _DEBUG, _WIN32, _M_IX86 600, __FILE__ "file", __cplusplus 199711L, _CPPUNWIND, __DATE__ "??? ?? ????", _WINDLL, _DLL, _NATIVE_WCHAR_T_DEFINED 1, _WCHAR_T_DEFINED 1, __COUNTER__ 0, _MSC_BUILD 1, _MSC_FULL_VER 191024629, WIN32, _INTEGRAL_MAX_BITS 64, __LINE__ 1, _MFC_VER 0x0E00, _M_IX86_FP 2]'
12:24:22.294 DEBUG org.sonar.cxx.CxxConfiguration - Defines (27)='[_UNICODE, _MT, __TIME__ "??:??:??", _MSC_VER 1910, _ATL_VER 0x0E00, __TIMESTAMP__ "??? ?? ???? ??:??:??", CODE_ANALYSIS, UNICODE, _DEBUG, _WIN32, _M_IX86 600, __FILE__ "file", __cplusplus 199711L, _CPPUNWIND, __DATE__ "??? ?? ????", _DLL, _CONSOLE, _NATIVE_WCHAR_T_DEFINED 1, _WCHAR_T_DEFINED 1, __COUNTER__ 0, _MSC_BUILD 1, _MSC_FULL_VER 191024629, WIN32, _INTEGRAL_MAX_BITS 64, __LINE__ 1, _MFC_VER 0x0E00, _M_IX86_FP 2]'

@Bertk Bertk mentioned this issue Dec 18, 2017
Merged
@jmecosta
Copy link
Member

Would it not be better to run this only once, and create a map of settings per file. This is the same as the clang compilations settings. So perhaps a refactoring to support build settings per file that can be used for all import methods.

@guwirth guwirth mentioned this issue Dec 27, 2017
Closed
@guwirth guwirth modified the milestones: 0.9.9, next Jan 1, 2018
@guwirth guwirth removed this from the next milestone Jan 16, 2018
@jeubank12 jeubank12 mentioned this issue Feb 13, 2018
Closed
@guwirth guwirth mentioned this issue Jan 12, 2019
Merged
@guwirth guwirth added this to the 2.0.0 milestone Jun 6, 2020
@guwirth guwirth self-assigned this Oct 20, 2020
@guwirth guwirth mentioned this issue Nov 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guwirth guwirth

Labels
enhancement
Milestone
2.0.0
3 participants
@jmecosta @Bertk @guwirth