Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto complete no longer shows local variables #36

Closed
ConnorAU opened this issue Oct 23, 2018 · 7 comments
Closed

Auto complete no longer shows local variables #36

ConnorAU opened this issue Oct 23, 2018 · 7 comments
Assignees
Labels

Comments

@ConnorAU
Copy link

After todays update, defined local variables no longer show in the autocomplete.
I tried toggling that new context setting but it didn't help. Disabling the extension fixed it.

@SkaceKamen SkaceKamen self-assigned this Oct 23, 2018
@SkaceKamen SkaceKamen added the bug label Oct 23, 2018
@SkaceKamen
Copy link
Owner

I'll look into it.

@Wyqer
Copy link

Wyqer commented Oct 23, 2018

As I guess it's some kind of connected to this, I don't open a new issue on this.

Since the update the findIf function is marked as "wrong" again.
Also it doesn't recognize local variables which are declared via params in the findIf scope.
As an overview I've put together an image of the errors.

errors

@SkaceKamen
Copy link
Owner

Oh, yea, I didn't know findIf existed, will add it in next update.

@Wyqer
Copy link

Wyqer commented Oct 23, 2018

As far as I know findIf was fine until the update. But I can be wrong, of course.
Basically we've now many "possibly undefined variable" warnings in our code. It seems there is an issue with scopes concerning select etc.

Again a picture which shows this strange behaviour.

localvariable

@SkaceKamen
Copy link
Owner

SkaceKamen commented Oct 23, 2018

Yea, that's because the system for checking correct combinations of commands is now more aggressive and won't allow you to just put something that isn't defined in middle of expression.

For the false positives, I forgot to add support for lambda functions (eg functions used in select and such) ... I'll have to work on that, in the meanwhile you can just disable the context aware checking.

@Wyqer
Copy link

Wyqer commented Oct 23, 2018

No critical problem at all, just wanted to report it. :)
I'm looking forward for the upcoming updates and really appreciate your work.

@SkaceKamen
Copy link
Owner

This issue is fixed in 0.9.1, issue with inline functions moved to #37

Dubjunk added a commit to KillahPotatoes/KP-Cratefiller that referenced this issue Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants