KPCF v1.1.0 publishing #23
Conversation
Polish translation thx @veteran29 !
Remove redundant stringtable entries thx @veteran29 !
.vscode/settings.json
Outdated
| "_import", | ||
| "_importName", | ||
| "_export", | ||
| "_exportName", |
There was a problem hiding this comment.
These four local variables don't need to be added here.
The issue that SQF Lint marked it as undefined is fixed.
Ref: SkaceKamen/vscode-sqflint#36
|
|
||
| // Black & whitelisting | ||
| _classNames = _classNames - KPCF_blacklistedItems; | ||
| _classNames append KPCF_whitelistedItems; |
There was a problem hiding this comment.
Shouldn't it be only one or another? 🤔
If you get _classnames by crawling, shouldn't it already have all whitelistedItems registered?
Maybe something like (pseudo code)
If elements in whitelistedItems, then _classnames = whitelistedItems
else crawl the configs to get all available items and remove everything which is listed in blacklistedItems
There was a problem hiding this comment.
Whitelisting is implemented as some kind of security feature, thought about items that won't be recognized like they should.
There was a problem hiding this comment.
Ah, I see.
As far as I know you've described it like that also in the config file. 👍
| }; | ||
| }; | ||
| }; | ||
| } forEach _classNames; |
There was a problem hiding this comment.
Couldn't directly say if it's really more performance friendly or if pushBackUnique is really noticeable performance heavier then pushBack, but you could think about:
As it seems you expecting to have some doubled classnames in the array (as you use pushBackUnique) you could sort out every doubled, etc. entries before the forEach or as forEach argument with
forEach (_classnames arrayIntersect _classnames); and use just pushBack in the switch.
Ref (example 2): https://community.bistudio.com/wiki/arrayIntersect
There was a problem hiding this comment.
nice idea, implemented it like that !
Co-Authored-By: Dubjunk <31448659+Dubjunk@users.noreply.github.com>
Co-Authored-By: Dubjunk <31448659+Dubjunk@users.noreply.github.com>
Co-Authored-By: Dubjunk <31448659+Dubjunk@users.noreply.github.com>
Co-Authored-By: Dubjunk <31448659+Dubjunk@users.noreply.github.com>
Co-Authored-By: Dubjunk <31448659+Dubjunk@users.noreply.github.com>
Co-Authored-By: Dubjunk <31448659+Dubjunk@users.noreply.github.com>
No description provided.