Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action summary and return status #826

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Action summary and return status #826

merged 2 commits into from
Dec 2, 2020

Conversation

tanema
Copy link
Contributor

@tanema tanema commented Oct 14, 2020 •
edited
Loading

fixes #823
fixes #822
fixes #738

This PR is an effort to collect runtime file operations data and present them at the end of the runtime. This will have multiple effects

  • Changed skipped color to cyan instead
  • Showing the summary (download, upload, deleted, skipped, errors) of changes for deploy remove download get new with a consistent theme between all.
  • Showing a count of errors
  • Showing an output of the errors that were encountered
  • Collecting error data to return status (still need to do) Currently themekit only sets error status if an error is returned however we need a way to return a general error if any were encountered during runtime
  • Set error status when errors happened during file changes
  • Make all fatal errors red.

image

Updated Screenshot:

image

TODO

  • Testing
  • Opting-out for commands like watch other non-file operations like open are not shown since no actions take place.
  • Set status

Warn Checklist

  • This changes the interface and requires a Major/Minor version change.
  • I have 🎩'd these changes by using the commands I changed by hand.
  • I have added a dependancy to the project.
  • I have considered any potential impact on node-themekit

@tanema tanema requested a review from andyw8 October 14, 2020 16:26
andyw8
andyw8 reviewed Oct 14, 2020
View reviewed changes
andyw8
andyw8 reviewed Oct 14, 2020
View reviewed changes
Add more tooling around summary and return status
56107f6 
- Added consistent summary output of file changes
- Added an error summary at the end of outputs
- Set error status when errors happened during file changes
- Make all fatal errors red
@tanema tanema force-pushed the action_summary_and_return_status branch from 3c964dd to 56107f6 Compare October 16, 2020 13:38
@tanema tanema marked this pull request as ready for review October 16, 2020 13:40
@tanema tanema mentioned this pull request Nov 20, 2020
Closed
4 tasks
@tanema tanema merged commit fa2ea64 into master Dec 2, 2020
@tanema tanema deleted the action_summary_and_return_status branch December 2, 2020 16:33
@tanema tanema mentioned this pull request Dec 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyw8 andyw8 andyw8 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

theme deploy errors silently theme download errors out "silently" "Skipped" text not visible in output
2 participants
@tanema @andyw8