You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If any file fails to upload (deploy), for example, a section file fails to upload because it has invalid schema, then deployment continues. Eventually, having deployment continue and finish, breaks the website, as the section file wasn't deployed along with all the other files.
Failing to upload any file should immediately fail the whole deployment.
To Reproduce
Steps to reproduce the behavior:
Open any section file in the theme.
Change "name" property inside of {% schema %} block to: "Collections Page Filter Header" (anything longer than 25 characters would do
Run theme deploy
Or
3.b Run theme deploy sections/<your-section-name>.liquid
Since we will not be merging anything around Black Friday/Cyber Monday, I have created a prerelease with the fixes for this issue included in it. You can install the prerelease by running theme update --version=v1.1.3-pre, please share any feedback that you have on this.
// related:
theme download
errors out "silently"If any file fails to upload (deploy), for example, a section file fails to upload because it has invalid schema, then deployment continues. Eventually, having deployment continue and finish, breaks the website, as the section file wasn't deployed along with all the other files.
Failing to upload any file should immediately fail the whole deployment.
To Reproduce
Steps to reproduce the behavior:
"name"
property inside of{% schema %}
block to:"Collections Page Filter Header"
(anything longer than 25 characters would dotheme deploy
Or
3.b Run
theme deploy sections/<your-section-name>.liquid
Run
echo $?
immediately after.Here's the sample output from `theme deploy`
Expected behavior
The command should fail.
echo $?
- prints last command's exit code. It's 0 for success and different from 0 for failure.It should print a non-zero code.
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: