Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] Account connection and setting toggle a11y docs #970

Merged
merged 5 commits into from
Feb 6, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UNRELEASED.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f

### Documentation

- Added accessibility documentation for the account connection and setting toggle components ([#970](https://github.com/Shopify/polaris-react/pull/970))
- Added accessibility documentation for the avatar component ([#973](https://github.com/Shopify/polaris-react/pull/973))
- Updated docs about App Bridge usage in AppProvider ([#945](https://github.com/Shopify/polaris-react/pull/945))

Expand Down
10 changes: 10 additions & 0 deletions src/components/AccountConnection/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,3 +166,13 @@ class AccountConnectionExample extends React.Component {
};
}
```

---

## Accessibility

<!-- content-for: web -->

See accessibility guidance for the [setting toggle component](/components/actions/setting-toggle) to turn connections on and off.

<!-- /content-for-->
12 changes: 12 additions & 0 deletions src/components/SettingToggle/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,3 +115,15 @@ class SettingToggleExample extends React.Component {
## Related components

- To let merchants to connect or disconnect their store to third-party services and apps, [use the account connection component](/components/actions/account-connection)

---

## Accessibility

<!-- content-for: web -->

The setting toggle component is implemented as an HTML `<button>`. The current label should convey what happens when the button is pressed.

To learn more about button accessibility, see the [button component](/components/actions/button).

<!-- /content-for-->