Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] Account connection and setting toggle a11y docs #970

Merged
merged 5 commits into from
Feb 6, 2019

Conversation

dpersing
Copy link
Contributor

@dpersing dpersing commented Feb 4, 2019

WHY are these changes introduced?

Adds accessibility guidance for the account connection and setting toggle components, to appear in polaris-react docs and in the style guide.

WHAT is this pull request doing?

  • Adds accessibility documentation for the account connection component (web only)
  • Adds accessibility documentation for the setting toggle component (web only)
  • Adds an entry to UNRELEASED.md

How to 🎩

  1. Check out master from polaris-styleguide to get the changes that support the accessibility section.
  2. In another Terminal tab or window, check out this branch from polaris-react and run the instructions for testing in a consuming project.
  3. In the polaris-styleguide tab, run dev up && dev start.
  4. View changes after examples and props:

Screenshots

Account connection

Screenshot of web-only account connection content

Setting toggle

Screenshot of web-only setting toggle content

@BPScott BPScott temporarily deployed to polaris-react-pr-970 February 4, 2019 22:15 Inactive
@dpersing dpersing changed the title [a11y] Account connection and settings toggle a11y docs [a11y] Account connection and setting toggle a11y docs Feb 4, 2019
@BPScott BPScott temporarily deployed to polaris-react-pr-970 February 4, 2019 22:17 Inactive
Copy link
Contributor

@sadiesaurus sadiesaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment to change future tense to present tense. Looks good!

@BPScott BPScott temporarily deployed to polaris-react-pr-970 February 6, 2019 20:45 Inactive
Co-Authored-By: dpersing <devon.persing@shopify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants