Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] change text-rendering to auto to fix Safari bug #2179

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

dleroux
Copy link
Contributor

@dleroux dleroux commented Sep 23, 2019

WHY are these changes introduced?

Fixes https://github.com/Shopify/web/issues/18619

As outlined here webkit has a bug that cause the browser to crash when a select text-rendering is set to optimizeLegibility

WHAT is this pull request doing?

Changes the text-rendering of the Select input to auto

How to 🎩

In the playground, navigate to the Select examples and ensure that on Safari 13 the browser doesn't crash.

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@dleroux dleroux changed the title [WIP][Select] change text-rendering to auto to fix Safari bug [Select] change text-rendering to auto to fix Safari bug Sep 23, 2019
Copy link
Contributor

@danrosenthal danrosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩

@dleroux dleroux merged commit 12bb54d into master Sep 23, 2019
@dleroux dleroux deleted the safari-13-fix branch September 23, 2019 14:56
@dleroux dleroux temporarily deployed to production September 23, 2019 15:28 Inactive
@dleroux dleroux temporarily deployed to production September 23, 2019 15:38 Inactive
@dleroux dleroux temporarily deployed to production September 23, 2019 16:59 Inactive
@dleroux dleroux temporarily deployed to production September 23, 2019 17:05 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants