Skip to content

Commit

Permalink
Merge pull request #2179 from Shopify/safari-13-fix
Browse files Browse the repository at this point in the history
[Select] change text-rendering to auto to fix Safari bug
  • Loading branch information
dleroux authored Sep 23, 2019
2 parents 0bdea25 + 2b6afbd commit 12bb54d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions UNRELEASED.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f
- Reverted `Page.primaryAction` forcing `primary` to be `true` ([#2137](https://github.com/Shopify/polaris-react/pull/2137))
- Removed `React.Children.only` from `AppProvider`and `ThemeProvider` ([#2121](https://github.com/Shopify/polaris-react/pull/2121))
- Fixed visual bug where button width changed in Filters component ([#1853](https://github.com/Shopify/polaris-react/issues/1853))
- Changed `text-rendering` to `auto` in `Select` to prevent Safari 13 from crashing ([#2179](https://github.com/Shopify/polaris-react/pull/2179))

### Documentation

Expand Down
2 changes: 2 additions & 0 deletions src/components/Select/Select.scss
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ $stacking-order: (
// Even though the input is invisible, text styles apply to the options menu
@include text-style-input;
position: absolute;
// Required to solve a bug causing Safari 13 to crash https://bugs.webkit.org/show_bug.cgi?id=202055
text-rendering: auto;
top: 0;
left: 0;
z-index: z-index(input, $stacking-order);
Expand Down

0 comments on commit 12bb54d

Please sign in to comment.