-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update developer dependencies #1327
Conversation
587da22
to
94b82c7
Compare
Looks like this adds a lot of duplicates, can we remove some by running an It looks like we'd also want to pull in the latest version of babel-plugin-shopify to shut up the coreJS complaining like what SK does in https://github.com/Shopify/sewing-kit/pull/1217 |
94b82c7
to
558b972
Compare
In my poking around with #1344 I think I've learnt that we want to either: update @babel/core and babel-plugin-shopify, or leave them both where they were. Using the latest will mean that the stand-alone build will be a bit bigger due to including corejs polyfills thanks to the babel-preset-env now using useBuiltIns: 'usage' (which changed in babel-plugin-shopify v18). This is due to our support for old ios. This doesn't affect polaris when used as part of sewing-kit because sk doesn't use the stand-alone build. I don't mind which one you go for. |
558b972
to
ac71482
Compare
ac71482
to
b2c1bd3
Compare
4a9f1e8
to
f7d436a
Compare
Ending up keeping this scoped to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tried this locally but tests are green and storybook looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh, that last review should have been green
f7d436a
to
ace5d7d
Compare
WHY are these changes introduced?
Second attempt to update deps 😄 #1187