Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #1187

Closed
wants to merge 3 commits into from
Closed

Update deps #1187

wants to merge 3 commits into from

Conversation

AndrewMusgrave
Copy link
Member

WHY are these changes introduced?

Keep up to date 😄

@BPScott BPScott temporarily deployed to polaris-react-pr-1187 March 13, 2019 18:54 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1187 March 13, 2019 19:02 Inactive
@kaelig
Copy link
Contributor

kaelig commented Mar 14, 2019

Can you try running npx yarn-dedupe yarn.lock and see if the build still passes?

The idea is to prevent some large dependencies (like puppeteer) to be downloaded in multiple versions (and perhaps even help with the polaris build size itself!).

@AndrewMusgrave
Copy link
Member Author

@kaelig It causes the build it fail. I'm a little confused though, I thought yarn install also does a de-dupe, what's the difference?

@chloerice
Copy link
Member

chloerice commented Mar 14, 2019

@AndrewMusgrave how do you recommend we tophat these changes? What are the potential break points if any? (Looks like no major version upgrades)

@AndrewMusgrave
Copy link
Member Author

@chloerice There isn't much we have to worry about. All the major updates happened to all be dev dependencies. Which includes, archiver, copyfiles, fs-extra, svgo and yargs. Most of the packages changes don't affect us. copy changed in fs-extra, and svgo.optimize now returns a promise. I would say the most important part of 🎩 this change is making sure the build is still 👌

@kaelig
Copy link
Contributor

kaelig commented Mar 14, 2019

@AndrewMusgrave yarn-install's dedupe is very conservative, which can be good for the developers but not always so great for the users or for build times.

Alternatively I sometimes edit the yarn.lock file manually, and group certain dependencies together. I checked in polaris-styleguide and node_modules/puppeteer is 195 MB, so it could be worth a quick manual edit here as well.

@chloerice chloerice requested review from kaelig and removed request for chloerice March 18, 2019 14:15
@kaelig kaelig removed their request for review March 20, 2019 03:22
Copy link
Member

@alex-page alex-page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndrewMusgrave requesting changes based on Kaeligs feedback.

@BPScott BPScott temporarily deployed to polaris-react-pr-1187 April 2, 2019 19:50 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1187 April 2, 2019 20:14 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1187 April 2, 2019 20:26 Inactive
@AndrewMusgrave
Copy link
Member Author

Taking another stab at updating deps from scratch #1327

@AndrewMusgrave AndrewMusgrave deleted the update-stale-deps branch September 30, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants