-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps #1187
Update deps #1187
Conversation
40ab731
to
5514635
Compare
Can you try running The idea is to prevent some large dependencies (like puppeteer) to be downloaded in multiple versions (and perhaps even help with the polaris build size itself!). |
@kaelig It causes the build it fail. I'm a little confused though, I thought |
@AndrewMusgrave how do you recommend we tophat these changes? What are the potential break points if any? (Looks like no major version upgrades) |
@chloerice There isn't much we have to worry about. All the major updates happened to all be dev dependencies. Which includes, archiver, copyfiles, fs-extra, svgo and yargs. Most of the packages changes don't affect us. |
@AndrewMusgrave yarn-install's dedupe is very conservative, which can be good for the developers but not always so great for the users or for build times. Alternatively I sometimes edit the yarn.lock file manually, and group certain dependencies together. I checked in polaris-styleguide and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndrewMusgrave requesting changes based on Kaeligs feedback.
5514635
to
c7d1bab
Compare
c7d1bab
to
0f993c3
Compare
0f993c3
to
ea26e7a
Compare
Taking another stab at updating deps from scratch #1327 |
WHY are these changes introduced?
Keep up to date 😄