Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lodash #1016

Closed
wants to merge 2 commits into from
Closed

Remove lodash #1016

wants to merge 2 commits into from

Conversation

AndrewMusgrave
Copy link
Member

WHY are these changes introduced?

Part of removing lodash #991

WHAT is this pull request doing?

Removing lodash 🎉

How to 🎩

Test pass? 💯

TODO:

  • add changelog
  • wait till the other pr's are merged and rebase 🎉

@BPScott BPScott temporarily deployed to polaris-react-pr-1016 February 11, 2019 22:19 Inactive
@danrosenthal
Copy link
Contributor

What's the status on this PR @AndrewMusgrave?

@yourpalsonja
Copy link
Contributor

Hey @AndrewMusgrave, I'm gonna close this PR since it's outdated, we should finish up the work against the v4 release.

@alex-page alex-page reopened this Aug 27, 2019
@alex-page
Copy link
Member

@AndrewMusgrave when you are back you will need to commit up your work in this branch and decide if it is worth doing for V5 or creating an issue to do this work at a later date and closing the PR.

@AndrewMusgrave
Copy link
Member Author

Closing this up for now - Main blocker is Shopify/quilt#829 - I'll open a new PR when we're ready

@AndrewMusgrave AndrewMusgrave deleted the rm-lodash branch September 19, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants