Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lodash / lodash-decorators #991

Closed
9 of 11 tasks
AndrewMusgrave opened this issue Feb 8, 2019 · 2 comments
Closed
9 of 11 tasks

Remove lodash / lodash-decorators #991

AndrewMusgrave opened this issue Feb 8, 2019 · 2 comments
Assignees
@AndrewMusgrave

Comments

@AndrewMusgrave
Copy link
Member

AndrewMusgrave commented Feb 8, 2019 •
edited
Loading

Lodash decorators

Lodash

Lodash in examples/create-react-app

Related - #980
@AndrewMusgrave AndrewMusgrave self-assigned this Feb 8, 2019
This was referenced Feb 11, 2019
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Merged
Merged
This was referenced Mar 8, 2019
Closed
Merged
@AndrewMusgrave AndrewMusgrave mentioned this issue May 27, 2019
Merged
@ghost
Copy link

ghost commented Oct 14, 2019

This issue has been inactive for 180 days and labeled with Icebox. It will be closed in 7 days if there is no further activity.

@ghost ghost added the Icebox label Oct 14, 2019
@sijad
Copy link
Contributor

sijad commented Oct 18, 2019

denounce is missed in above list:

https://github.com/Shopify/polaris-react/blob/b16c134fe6e450daf04a94c60d76e121ee118c8d/src/components/MediaQueryProvider/MediaQueryProvider.tsx#L2
https://github.com/Shopify/polaris-react/blob/44060b1ef10a346408675af954d48e03ac1286f6/src/components/Frame/components/Loading/Loading.tsx#L2
...

isEqual can replaced with https://www.npmjs.com/package/fast-deep-equal or https://www.npmjs.com/package/react-fast-compare

@ghost ghost closed this as completed Oct 25, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewMusgrave AndrewMusgrave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yourpalsonja @sijad @AndrewMusgrave