Skip to content

Commit

Permalink
Improve accessibility of Link focus style
Browse files Browse the repository at this point in the history
  • Loading branch information
ry5n committed May 10, 2019
1 parent cd868a1 commit a2c09ff
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
1 change: 1 addition & 0 deletions UNRELEASED.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f
### Bug fixes

- Fixed `Popover` fade-in flutter on iOS by switching Transition component for CSSTransition [#1400](https://github.com/Shopify/polaris-react/pull/1400)
- Improved the visibility of focus styles for the `Link` component. [#1425](https://github.com/Shopify/polaris-react/pull/1425)

### Documentation

Expand Down
4 changes: 1 addition & 3 deletions src/components/Link/Link.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,14 @@
text-align: inherit;
padding: 0;
background: none;
border: none;
border: 0;
font-size: inherit;
color: color('blue');
text-decoration: none;
cursor: pointer;

&:hover,
&:focus,
&:active {
outline: none;
color: color('blue', 'dark');
}
}
Expand Down
13 changes: 7 additions & 6 deletions src/styles/shared/links.scss
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,12 @@
transition: opacity duration() easing();
}

&:hover,
&:focus,
&:active {
&::after {
opacity: 0.4;
}
&:hover::after,
&:active::after {
opacity: 0.4;
}

&:focus::after {
display: none;
}
}

0 comments on commit a2c09ff

Please sign in to comment.