Small fix in checkbox logic (#1453)

Shopify · May 10, 2019 · cd868a1 · cd868a1
1 parent ba0224a
commit cd868a1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/UNRELEASED.md b/UNRELEASED.md
@@ -28,4 +28,6 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f
 
 ### Code quality
 
+- Simplified logic in Checkbox component ([#1453](https://github.com/Shopify/polaris-react/pull/1453))
+
 ### Deprecations
diff --git a/src/components/Checkbox/Checkbox.tsx b/src/components/Checkbox/Checkbox.tsx
@@ -53,8 +53,8 @@ class Checkbox extends React.PureComponent<CombinedProps, never> {
 
   componentDidUpdate({disabled: prevDisabled}: Props) {
     if (
+      prevDisabled === true &&
       this.props.disabled &&
-      !prevDisabled !== true &&
       this.inputNode.current &&
       this.inputNode.current.checked
     ) {
Original file line number	Diff line number	Diff line change
Expand Up		@@ -28,4 +28,6 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f

		### Code quality

		- Simplified logic in Checkbox component ([#1453](https://github.com/Shopify/polaris-react/pull/1453))

		### Deprecations