[Checkbox] Small fix in checkbox logic #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrosenthal
previously approved these changes
May 10, 2019
| this.props.disabled && | ||
| !prevDisabled !== true && |
There was a problem hiding this comment.
This makes my eyes go crossed. Good fix
There was a problem hiding this comment.
Obviously could just make this prevDisabled &&, but I'd rather avoid Type Coercion.
danrosenthal
dismissed
their stale review
Looks like it's actually breaking in CI...
keyfer
force-pushed
the
checkbox/small-tweak
branch
from
4f08a85 to
adc45be
Compare
danrosenthal
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Saw this code while running through some component logic, thought it was worth the quick fix.
WHAT is this pull request doing?
Simple fix to checkbox logic.
README.mdwith documentation changes